Code Monkey home page Code Monkey logo

Comments (3)

shishirmk avatar shishirmk commented on July 17, 2024 1

@devtoro we always look for relationship_model_name_ids(movie_ids) first as it is an optimization mechanism. It is common to just serialize only the ids unless the relationship is in the includes list. This saves unnecessary fetching of objects and object creation.

Looks like in your case you are saying if the relationship_model_name_ids(movie_ids) method doesn't exist then instead of throwing an error or skipping serialization altogether, we should fallback on the relationship_model_names(s)(movies) method to get the id.

I think this request makes sense. Do you think you can take a shot at implementing it?

from fast_jsonapi.

shuheiktgw avatar shuheiktgw commented on July 17, 2024

PRed! #151

from fast_jsonapi.

devtoro avatar devtoro commented on July 17, 2024

Sorry for the late reply...I had certain issues to attend and could not participate further.

What's the status on this?

Is #151 merged? Shall I take some action? I would gladly implement it if it's necessary. :)

from fast_jsonapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.