Generated constants could be hard to read about dgs-codegen HOT 4 CLOSED

Hi @marceloverdijk , thanks for making the suggestions. I'm working on a PR for this since a team internally requires it, will keep you updated.

from dgs-codegen.

@marceloverdijk PR out #104

from dgs-codegen.

I would also like that :-)

In ConstantsGenerator currently the GraphQL definition name is simply upper cased like:

    private fun createConstantTypeBuilder(name: String): TypeSpec.Builder {
        return TypeSpec.classBuilder(name.toUpperCase())
            .addModifiers(Modifier.PUBLIC, Modifier.STATIC)
    }

This could be changed to e.g. (of course with a flag for backwards compatibility):

    private fun createConstantTypeBuilder(name: String): TypeSpec.Builder {
        return TypeSpec.classBuilder(name.replaceAll("(.*)([A-Z])", "$1_$2").toUpperCase())
            .addModifiers(Modifier.PUBLIC, Modifier.STATIC)
    }

This would result in: DGS_ARTIFACT_VERSION_IN_ENVIRONMENT

Some other examples:

• IMDbMovie --> IMDB_MOVIE
• G2AVoucher --> G2A_VOUCHER

from dgs-codegen.

Now only need to think of a good flag name; can't think of anything better than generateUnderscoreInConstantNames/useUnderscoreInConstantNames

@srinivasankavitha / @paulbakker Wdyt? As I could provide a PR for this.

from dgs-codegen.