Code Monkey home page Code Monkey logo

Comments (3)

mkrogemann avatar mkrogemann commented on May 30, 2024

I did some more research into this and one possible fix that looks quite uninvasive is to change the 'key' property of the Entity SecurityGroup to groupId instead of groupName.
I will submit a pull request with the required changes.

from asgard.

claymccoy avatar claymccoy commented on May 30, 2024

This is a known problem, but it hasn't bothered us enough yet to fix. You are correct about the cache being keyed by name rather than id. The invasive part is finding all the cache lookups and making sure they are all done by id. In many EC2 cases you won't even have ids. You may need to do a lookup or have caches for name and id.
A pull request would be welcomed.

from asgard.

cquinn avatar cquinn commented on May 30, 2024

I agree with this suggestion and could use this functionality as well. In our case, we might also have multiple VPCs (since EC2-Classic is going away). I suggest the following changes:

  • change all internal code security group references to use groupId
  • make sure all generated url link references are groupId as well
  • change the UI presentation for security groups to include a scoped name as well as an Id. Something like: "tools:secure [sg-1234]"

from asgard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.