Code Monkey home page Code Monkey logo

Comments (3)

luisj1983 avatar luisj1983 commented on August 22, 2024

Note that the readme says:

The devenv includes all the dependencies required to develop for the following repositories:

netdata/netdata
netdata/dashboard
netdata/go.d.plugin
netdata/helmchart

And so we should think about pushing at least to those.

I am wondering whether a solution would be to convert the devcontainer.json in this repo into a devcontainer template as per here:
https://containers.dev/implementors/templates/
And then each repo could have a well-known named file such as devcontainer_custom.json which would be referenced the devcontainer.json and contain any repo specific settings.

from community.

ilyam8 avatar ilyam8 commented on August 22, 2024

@luisj1983 updating the readme is an alternative option, keep it in mind 😄

from community.

luisj1983 avatar luisj1983 commented on August 22, 2024

@ilyam8
Sure but all that really matters is whether Netdata team want the devcontainer stuff in your repos or not :-D
My view is that it adds value by lowering the bar to entry for contributing and ensuring consistency.
If the above is a good idea then the only question is whether it gets supported well or poorly; and having to keep files like that manually in sync doesn't feel like the best option (in fact, it feels a lot like more work).
Who might own the code and be responsible for its upkeep is different question and a valid concern; one I think I'd be happy to assist with (if that helps at all).

from community.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.