Code Monkey home page Code Monkey logo

Comments (3)

frankmoto avatar frankmoto commented on May 14, 2024 3

I ran into a similar issue and I got around it by doing a bit more leg work. What you could do for the time being is create a new Module called BoardStoryModule and extend your story module, then import the BoardStoryModule into your routing document and use it.

from nest-router.

shekohex avatar shekohex commented on May 14, 2024

well, in this case, I'd recommend using regex to match both paths, since I think that the only way we can do it since Nestjs is already supporting path regex:
The best regex here should be: ^boards\/(?:([^\/]+?))\/stories|^stories(?=\/|$)

I know it seems complicated, but can we do better?

See it in action here: https://regex101.com/r/R7IxYM/2

this is helpful too: http://forbeslindesay.github.io/express-route-tester/

from nest-router.

Discountrobot avatar Discountrobot commented on May 14, 2024

We have a similar issue, with dynamic modules.

When trying to setup the router on two different modules utilising the same shared module dynamically initialised.

Setup as follows:

const AnimalModuleInstance1: DynamicModule = {
    module: SharedModuleWithRoutes,
};

const AnimalModuleInstance2: DynamicModule = {
    module: SharedModuleWithRoutes,
};

const DOG_ROUTES: Routes = [
    {
        path: '/1/',
        module: DogModule,
        children: [
            AnimalModuleInstance1.module,
        ]
    }
];

const CAT_ROUTES: Routes = [
    {
        path: '/2/',
        module: CatModule,
        children: [
            AnimalModuleInstance2.module,
        ]
    }
];

We run into issues as the router module tries to reference the module based on the nestModule.metatype which will be "SharedModuleWithRoutes"

const modulePath: string = Reflect.getMetadata(MODULE_PATH, nestModule.metatype);

setting the base path to either /2/ or /1/ to both modules depending on which module is initialised last.

changing the reflector to use the module object reference rather than the metatype seems to resolve our issue - however will not work if string based module references are allowed in children property interface.

- const modulePath: string = Reflect.getMetadata(MODULE_PATH, nestModule.metatype);
+ const modulePath: string = Reflect.getMetadata(MODULE_PATH, nestModule);

from nest-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.