ApiModelProperty always sets required:true when custom type provided about swagger HOT 8 CLOSED

You should use @ApiModelPropertyOptional()

from swagger.

Thanks for looking into the issue. Unfortunately the fix doesn't work properly and Custom Object Models are still always shown as "Required" (marked with a red star) in the SwaggerUI. I checked the commits on master and apparently you changed the code to the suggestion which was provided - so maybe this suggestion isnt correct?

    @ApiModelProperty({ description: 'Process Metadata', required: true,
        type: ProcessData, isArray: false })
    @ValidateNested()
    @Type(() => ProcessData)
    processData: ProcessData;

    @ApiModelPropertyOptional({ description: 'Customer Data',
        type: CustomerData, isArray: false })
    @ValidateNested()
    @Type(() => CustomerData)
    customerData: CustomerData;

    @ApiModelPropertyOptional({ description: 'Vehicle Data',
        type: VehicleData, isArray: false })
    @ValidateNested()
    @Type(() => VehicleData)
    vehicleData: VehicleData;

All three attributes are still shown as "required".

from swagger.

@darioxtx it's up to you, it's the same but just shorter notation, anyway @ApiModelPropertyOptional() has the same issue be course it's just a wrapper around @ApiModelProperty()

from swagger.

In our project we discovered the same issue and would be very happy about a fix

from swagger.

Thanks, fixed. I'll publish it soon. 🔥

from swagger.

I confirm the issue outlined by @NiklasMencke

Can a fix be provided for this too ? Basically required is still appearing for objects, eg:

@ApiModelPropertyOptional({type: ChannelDto})
channel: ChannelDto;

from swagger.

Fixed in 2.1.0

from swagger.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from swagger.