Comments (4)
@kamilmysliwiec just saw your related issue :)
I found out that we can pass a parameter to Passport to expose the ExecutionContext :)
Using super({ passReqToCallback: true });
in the class, enables to see the request (it's a parameter from PassportJS). From there, we can read parameters from the URL, queries, and many other things :)
@Injectable()
export class BearerStrategy extends PassportStrategy(Strategy) {
constructor(
private readonly authService: AuthService,
private readonly tokenService: AccessTokenService,
) {
// passReqToCallback allows to have the request in the validate() function
super({ passReqToCallback: true });
}
/**
* Function to check that a given token is valid
* @param request
* @param token Token to be validated
* @param done Callback when finished
* @returns {Promise<any>}
*/
async validate(request: IncomingMessage, token: string, done) {
// Fetch a user by a token
const user = await this.authService.validateToken(token);
// No matching user found or Token Expired
if (!user) {
return done(new UnauthorizedException(), false);
}
const allowAccess = await this.authService.validateACL(user.id, request);
allowAccess ? done(null, user) : done(new UnauthorizedException(), false);
}
}
from passport.
Ok, after some more research, it's not possible to add the nestjs context into the passportjs context. The reason is that passport expects a request object, nothing else.
Finally I used a different approach: use the nestjs/passport module to do authentication. This module sets the user value back in the response object in the context.
Then in a second guard, I do authorization, using the precalculated user data in the previous guard.
This now works as expected ;)
from passport.
Hi, another update. Seems the only context exposed is the HTTP one. In order to use reflectors, this would need the original context. So still, this wouldn't be possible to be fixed with the solution I found. The best solution would be to expose by default the whole context in the validate function, instead of the incoming message
from passport.
Use the nestjs/passport module to do authentication. This module sets the user value back in the response object in the context. Then in a second guard, I do authorization, using the precalculated user data in the previous guard.
This ^ solution sounds like the best possible one 🙂
from passport.
Related Issues (20)
- passport-steam Guide will be appreciated HOT 1
- How about changing the constructor parameter type of PassportStrategy like this? HOT 1
- validate(payload: any) in Implementing Passport JWT doc it's not correct HOT 2
- AuthGuard on Local Strategy return undefinded HOT 1
- overwhelmed by error logs HOT 6
- Pretty magical thing: request.authInfo = undefined and behavior is very strange HOT 3
- Unable to preserve session in passport v0.6.0 HOT 2
- v10 does not allow typing on custom `getRequest` method in class with extended AuthGuard HOT 1
- AuthGuard does not work with authentication-only strategies HOT 1
- Support for [email protected] HOT 3
- using @Inject(REQUEST) req breaks passport. HOT 4
- Guard Order Scope affects order of execution HOT 2
- Can a new release be pushed? HOT 3
- Nest can't resolve dependencies of the JwtAuthenticationGuard after upgrade 8.1.0 to 8.1.1 HOT 9
- Cannot read properties of undefined (reading 'property') HOT 1
- Using custom passport from a different package causes error HOT 1
- Dependency tree discrepancy HOT 2
- PassportStrategy interface does not contain validate() HOT 2
- The defaultStrategies cannot be set during runtime in the AuthGuard HOT 1
- Typing of the result of getAuthenticateOptions is misleading/incorrect HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passport.