Comments (7)
I guess i can also say this is due to issue #21
https://github.com/nestjs/passport/issues/21
from passport.
Another thing i would like to note is that I tried to use an interceptor for common logic but it was not executing (as expected?)
@Get('login/azure')
@UseGuards(AuthGuard('azure'))
@UseInterceptors(PassportLoginInterceptor)
@ApiOperation({title: 'Handles the azure login'})
public loginAzure() {
return {};
}
from passport.
Please, provide a minimal repository which reproduces your issue.
from passport.
Here's an example repo:
https://github.com/boenrobot/nestjs-issues/tree/master/auth-guard-nondry
I have a different use case, but same request...
I want to invert the way auth guards are applied - have all routes protected by default, except those featuring a custom decorator called @Public
. I can do that, but adding support for it is done per authentication strategy, which means lots of duplicated code, and one more thing to remember doing if a new auth method is added.
In the example, I've added two local strategies, but you can imagine an app with various other auth methods (Google, Facebook, etc.). The files with duplicated code are public-aware-auth-local-primary.guard.ts
and public-aware-auth-local-secondary.guard.ts
.
from passport.
Would you like to create PR for this issue?
from passport.
There is no enough bandwidth to fix this issue.
from passport.
I thought you might like this.
controller
type Provider = 'google' | 'facebook';
@Controller()
export class AuthController {
@Get(':provider')
@UseGuards(OauthGuard)
public async googleOauth(@Param() provider: Provider) {
Logger.log(`${provider} login`);
}
}
guard
@Injectable()
export class OauthGuard implements CanActivate {
canActivate(
context: ExecutionContext,
): boolean | Promise<boolean> | Observable<boolean> {
const { provider } = context.switchToHttp().getRequest().params;
const Guard = AuthGuard(provider);
return new Guard('google').canActivate(context);
}
}
from passport.
Related Issues (20)
- passport-steam Guide will be appreciated HOT 1
- How about changing the constructor parameter type of PassportStrategy like this? HOT 1
- validate(payload: any) in Implementing Passport JWT doc it's not correct HOT 2
- AuthGuard on Local Strategy return undefinded HOT 1
- overwhelmed by error logs HOT 6
- Pretty magical thing: request.authInfo = undefined and behavior is very strange HOT 3
- Unable to preserve session in passport v0.6.0 HOT 2
- v10 does not allow typing on custom `getRequest` method in class with extended AuthGuard HOT 1
- AuthGuard does not work with authentication-only strategies HOT 1
- Support for [email protected] HOT 3
- using @Inject(REQUEST) req breaks passport. HOT 4
- Guard Order Scope affects order of execution HOT 2
- Can a new release be pushed? HOT 3
- Nest can't resolve dependencies of the JwtAuthenticationGuard after upgrade 8.1.0 to 8.1.1 HOT 9
- Cannot read properties of undefined (reading 'property') HOT 1
- Using custom passport from a different package causes error HOT 1
- Dependency tree discrepancy HOT 2
- PassportStrategy interface does not contain validate() HOT 2
- The defaultStrategies cannot be set during runtime in the AuthGuard HOT 1
- Typing of the result of getAuthenticateOptions is misleading/incorrect HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passport.