I'm submitting a...Bug report
[ ] Regression
[*] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
Hello,
I'm using the graphql example( in the example directory of nest) with the Cat CRUD and i try to use a union type and interface but i didn't find a way to do it.
When i try to request my data with a fragment, i have the following error :
"Abstract type MutationResult must resolve to an Object type at runtime for field Mutation.createCat with value "[object Object]", received "undefined". Either the MutationResult type should provide a "resolveType" function or each possible types should provide an "isTypeOf" function."
There is nothing in the doc explaining how to use union / interface, and there is nothing in the graphql example.
In the apollo documentation, the type resolver ( here "Cat" Resolver") should implement a __resolveType function. I tried to set this function in the @resolver('Cat') class CatsResolvers
but it's not working.
I tried to add it on the cat resolvers class
Expected behavior
The request should return either a Cat item or GraphQLErrorItem from my schema definition.
Minimal reproduction of the problem with instructions
export interface GraphQLError {
readonly message: string;
readonly errorCode: number;
readonly type: string;
}
type GraphQLError {
message: String
errorCode: Int
type: String
}
union MutationResult = Cat | GraphQLError
- change the createCat Mutation in the schema
- createCat(name: String, age: Int): MutationResult
- add the function in cats.resolvers.ts in the CatsResolvers class
__resolveType(obj, context, info): string{
return obj.errorCode ? 'GraphQLError' : 'Cat';
}
What is the motivation / use case for changing the behavior?
Environment
Nest version: 4.5.10 (core)
For Tooling issues:
- Node version: 9.4
- Platform: Mac
Others:
Does this package support Apollo Server 2.0 or the older version? I installed their release candidate for express ([email protected]). graphqlExpress is no longer available. import { graphqlExpress } from 'apollo-server-express'; How would I go about using nestjs/graphql with Apollo Server 2.0?
thank you
In @query, we get the parameters (args, context, info) like this
@Query()
user(_, args, context, info) {
And req can be retrieved from context or info
Is it possible to get the req from @ResolveProperty too? I have tried something like this but it does not work.
@ResolveProperty()
userExperience(user: user, @Req() request) {
how to test graphql use nestjs
I'm submitting a...
[ ] Regression
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
I want to implement two endpoints. For this goal I have two modules: AdminModule and SiteModule. In each module I imported GraphQLModule:
GraphQLModule.forRootAsync({
useFactory: async () => {
return {
typePaths: ['./src/admin/**/*.graphql'],
path: '/admin',
}
},
})
and
GraphQLModule.forRootAsync({
useFactory: async () => {
return {
typePaths: ['./src/site/**/*.graphql'],
path: '/site',
}
},
})
In this case only /admin is available. When I request /site it returns 404. From another side I can use forRoot instead of forFootAsync. In this case both endpoints work as expected. But I have to use forRootAsync for have possibility to define allowResolversNotInSchema: true by the issue described in #19. Without It I get error: Error: "Mutation" defined in resolvers, but not in schema when in shared module I add some resolver which defined only in one of two schemes.
Expected behavior
Possibility for implement multiple endpoints
Minimal reproduction of the problem with instructions
- Use with example https://github.com/nestjs/nest/tree/master/sample/12-graphql-apollo/src
- Add two modules with configs as described above.
What is the motivation / use case for changing the behavior?
It is very convenient for have possibility for split public and protected API.
Environment
Nest version: 5.3.0
For Tooling issues:
- Node version: 10.1.0
- Platform: Windows
I found an issue regarding guards. Let's take the following example:
import { Injectable, CanActivate, ExecutionContext } from '@nestjs/common';
import { Observable } from 'rxjs';
import { Reflector } from '@nestjs/core';
@Injectable()
export class RolesGuard implements CanActivate {
constructor(private readonly reflector: Reflector) {}
canActivate(context: ExecutionContext): boolean {
const roles = this.reflector.get<string[]>('roles', context.getHandler());
if (!roles) {
return true;
}
const request = context.switchToHttp().getRequest();
const user = request.user;
return user && user.role && roles.some((role) => role === user.role));
}
}
Now, in the rest of the framework this works like a charm. But whenever you are in graphql, this doesn't work quite as well. Taking the following .gql file.
type Bookings implements Node {
id: ID!
...
}
type BookingEdge {
cursor: ID!
node: Booking
}
type BookingConnection {
edges: [BookingEdge]
nodes: [Booking]
pageInfo: PageInfo!
totalCount: Int!
}
type Restaurant implements Node {
id: ID!
orders(first: Int, after: String, last: Int, before: String):OrderConnection
...
}
type Query {
restaurant(id: ID!): Restaurant
}
For the following query, the const request = context.switchToHttp().getRequest(); becomes the user.
query ($id: ID!) {
restaurant(id: $id) {
id
bookings {
nodes {
id
}
}
}
}
So, in this query, request.user in the guard, becomes undefined and you have to make a workaround:
canActivate(context: ExecutionContext): boolean | Promise<boolean> {
const roles = this.reflector.get<string[]>('roles', context.getHandler());
const request = context.switchToHttp().getRequest(); //this works only for when querying a parent type
const ctx = context.getArgByIndex(2); // this works for when querying a child.
const user = request.user || ctx.user;
return user && user.role && roles.some((role) => role === user.role));
}
Can you guys check if it happens to you or it's an issue of mine? Thank you.
Hi,
I have an issue, when merge types and create schema, on terminal console show errors like this:
node:8726) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): TypeError: buildASTSchema.getDescription is not a function
(node:8726) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled willterminate the Node.js process with a non-zero exit code.
this is my code
const typeDefs = this.graphQLFactory.mergeTypesByPaths('./**/*.graphql');
const schema = this.graphQLFactory.createSchema({ typeDefs });
consumer
.apply(graphqlExpress(req => ({ schema: {}, rootValue: req })))
.forRoutes({ path: '/graphql', method: RequestMethod.ALL });
Hi, I am new to NestJS, so I hope this issue is not my mistake. I think NestJS's GraphQL module does not support resolvers that returns observables. This is kind of unexpected as the REST counterpart (i.e. controllers) supports observables.
With heyPromise, I am able to get 'from promise'. However, heyObservable returns this instead:
{
"data": {
"heyObservable": "[object Object]"
}
}
The expected data for heyObservable should be 'from rxjs'. For now, we will need to workaround by turning the observable into a promise (i.e. heyObservable_workaround_is_ok)
Snippet of schema & resolvers used:
type Query {
heyPromise: String
heyObservable: String
}
@Query()
async heyPromise () {
return new Promise(resolve => resolve('from promise'))
}
@Query()
heyObservable () {
return of('from rxjs')
}
@Query()
heyObservable_workaround_is_ok () {
return of('from rxjs').toPromise()
}
I'm submitting a...
[ ] Regression
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
{
"error": "Could not connect to websocket endpoint ws://localhost:3000/graphql. Please check if the endpoint url is correct."
}Expected behavior
It should subscribe to changes.
Minimal reproduction of the problem with instructions
Checkout https://github.com/nestjs/nest/tree/master/sample/12-graphql-apollo
Fire subscription query
subscription {catCreated {id name}}What is the motivation / use case for changing the behavior?
Well its a bug - so ^^
Environment
Nest version: latest
For Tooling issues:
- Node version: 9
- Platform Mac
Trying to configure GraphQL subscriptions using existing express server.
But seems that there is some kind of conflict.
Error thrown in graphiql console:
WebSocket connection to 'ws://localhost:3000/subscriptions' failed: Connection closed before receiving a handshake response
When using new server. There is no error.
Here the graphQL configuration I've used:
this.setSameServer() - uses nest http server instance.
this.setDifferentServer() - uses new http instance.
import {
MiddlewareConsumer,
Module,
HttpServer,
Inject,
NestModule,
OnModuleDestroy,
} from '@nestjs/common';
import { AppController } from 'app.controller';
import { AppService } from 'app.service';
import { graphqlExpress, graphiqlExpress } from 'apollo-server-express';
import { GraphQLModule, GraphQLFactory } from '@nestjs/graphql';
import { AuthorResolver } from 'author.resolver';
import { SubscriptionServer } from 'subscriptions-transport-ws';
import { execute, subscribe } from 'graphql';
import { createServer } from 'http';
import { HTTP_SERVER_REF } from '@nestjs/core';
@Module({
imports: [GraphQLModule, AuthorResolver],
controllers: [AppController],
providers: [
{
provide: 'SUBSCRIPTION_SERVER',
useFactory: () => {
const server = createServer();
return new Promise(resolve => server.listen(88, () => resolve(server)));
},
},
AppService,
],
})
export class AppModule implements NestModule, OnModuleDestroy {
private subscriptionServer: SubscriptionServer;
private subscriptionPort: number;
private wsServer: HttpServer;
constructor(
private readonly graphQLFactory: GraphQLFactory,
@Inject(HTTP_SERVER_REF) private readonly httpServerRef: HttpServer,
@Inject('SUBSCRIPTION_SERVER') private readonly ws: HttpServer,
) {
this.setSameServer();
//this.setDifferentServer();
}
private setSameServer() {
this.wsServer = this.httpServerRef.getHttpServer();
this.subscriptionPort = 3000;
}
private setDifferentServer() {
this.wsServer = this.ws;
this.subscriptionPort = 88;
}
public configure(consumer: MiddlewareConsumer) {
const typeDefs = this.graphQLFactory.mergeTypesByPaths('./**/*.graphql');
const schema = this.graphQLFactory.createSchema({ typeDefs });
const route = '/graphql';
const routeIDE = '/graphiql';
const routeSubs = '/subscriptions';
const middlewareIDE = graphiqlExpress({
endpointURL: route,
subscriptionsEndpoint:
'ws://localhost:' + this.subscriptionPort + routeSubs,
});
const middleware = graphqlExpress(req => ({
schema,
rootValue: req,
debug: false,
}));
consumer.apply(middleware).forRoutes(route);
consumer.apply(middlewareIDE).forRoutes(routeIDE);
this.subscriptionServer = new SubscriptionServer(
{
execute,
subscribe,
schema,
},
{
server: this.wsServer,
path: routeSubs,
},
);
}
public onModuleDestroy() {
this.subscriptionServer.close();
}
}Used these issues for help:
nestjs/nest#500
#6
And full repo if you want to reproduce:
https://github.com/ph55/nest-graphql-subscriptions
I have following code:
import {
Module,
MiddlewaresConsumer,
NestModule,
RequestMethod,
} from '@nestjs/common';
import { graphqlExpress } from 'apollo-server-express';
import { GraphQLModule, GraphQLFactory } from '@nestjs/graphql';
import {UsersModule} from './Users/users.module';
@Module({
imports: [GraphQLModule],
modules: [UsersModule],
export class ApplicationModule {
constructor(private readonly graphQLFactory: GraphQLFactory) {}
}
And application exits with following error:
[Nest] 24011 - 2018-2-13 13:06:05 [NestFactory] Starting Nest application...
[Nest] 24011 - 2018-2-13 13:06:05 [ExceptionHandler] Nest can't resolve dependencies of the ApplicationModule (?). Please verify whether [0] argument is available in the current context.
Error: Nest can't resolve dependencies of the ApplicationModule (?). Please verify whether [0] argument is available in the current context.
at Injector.<anonymous> (/home/tymur/Learning/nest/project/node_modules/@nestjs/core/injector/injector.js:160:23)
at Generator.next (<anonymous>)
at fulfilled (/home/tymur/Learning/nest/project/node_modules/@nestjs/core/injector/injector.js:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:160:7)
at Function.Module.runMain (module.js:703:11)
at startup (bootstrap_node.js:190:16)
at bootstrap_node.js:662:3
1: node::Abort() [node]
2: 0x8c8099 [node]
3: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [node]
4: 0xaddc5c [node]
5: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node]
6: 0x3ab9ebd042fd
Aborted (core dumped)
UsersModule is dummy module:
import {Module} from '@nestjs/common';
import {UsersService} from './users.service';
import UsersController from './users.controller';
import {usersProviders} from './users.providers';
import {DatabaseModule} from '../common/database/database.module';
import {LibrariesModule} from '../Libraries/libraries.module';
import {UserResolver} from './user.resolver';
@Module({
// modules: [DatabaseModule, LibrariesModule],
// controllers: [UsersController],
// components: [
// UsersService,
// ...usersProviders,
// UsersResolver,
// ],
// exports: [
// UsersService,
// ],
})
export class UsersModule {}
but if i comment out modules: [UsersModule], in ApplicationModule, everithing works fine. Same as commenting out constructor in application module. What im doing wrong?
Hey, I want know a possibility to send an array of errors using the GraphQL module.
Is it possible with GraphQL module using a mutation? I have no idea how to implement it.
Big thanks.
With @nestjs/graphql, how to generate document for graphql api ?
There is No Description.
My AppModule have this configuration https://docs.nestjs.com/graphql/quick-start, but a need to upload a file with multipart/form-data, i added a new Module with a Controller with this method:
@Post('upload') @UseInterceptors(FileInterceptor('file', { storage })) async uploadFile(@UploadedFile() file, @Response() res) { return {}; }
this method never respond to a client
Hallo,
in a previous release there has been the GraphQLFactory provider with the createSchema()-function. This has been removed and it seems there is no way to pass merged GraphQL types to GraphQLModule.forRoot(). Am I right or did I overlook something?
What is the reason to remove support for predefined types?
My use case is this: I have a multi-repo project and one of them returns the merged types. Until now I have simply passed them to createSchema(), but now I have to update to the latest nestjs/graphql version (I need the Root()-decorator).
Thanks,
Steven
Recommend Projects
-
-
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
An Open Source Machine Learning Framework for Everyone
-
The Web framework for perfectionists with deadlines.
-
A PHP framework for web artisans
-
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
Some thing interesting about web. New door for the world.
-
A server is a program made to process requests and deliver data to clients.
-
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Some thing interesting about visualization, use data art
-
Some thing interesting about game, make everyone happy.
-
Recommend Org
-
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Open source projects and samples from Microsoft.
-
Google ❤️ Open Source for everyone.
-
Alibaba Open Source for everyone
-
Data-Driven Documents codes.
-
China tencent open source team.
-
![renovate[bot] avatar](https://avatars.githubusercontent.com/in/2740?v=4 "renovate[bot]")
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
React
Typescript
Django
Laravel
Facebook
Microsoft
Google
Alibaba
D3
Tencent