Code Monkey home page Code Monkey logo

Comments (10)

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024 2

Thanks for sharing your use-cases @matcic @michaelbromley, appreciate that ❤️ I have just published 5.2.0, you can use GraphQLTypesLoader now (exported from the root).

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024 1

Fixed in v5.1.1. Thanks for reporting!

from graphql.

michaelbromley avatar michaelbromley commented on March 29, 2024

This still appears to be broken for me in v5.1.1.

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024

Weird 😢 Reopening

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024

Alright.
So basically GraphQLFactory depends on ResolversExplorerService and a few others which in turn depends on GRAPHQL_MODULE_OPTIONS. It creates a circular infinite dependency. Since mergeTypesByPaths doesn't need options object, we could extract this method to another class.

from graphql.

matcic avatar matcic commented on March 29, 2024

@kamilmysliwiec I was about to open the same issue and was going to suggest what you just said. Just in case the following is what I'm using for now @michaelbromley:

import { fileLoader, mergeTypes } from 'merge-graphql-schemas';
import { flatten } from 'lodash';

export function mergeGraphqlTypes(...patterns: string[]): string {
  const files = patterns.map(pattern => fileLoader(pattern));
  return mergeTypes(flatten(files));
}

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on March 29, 2024

One question @matcic @michaelbromley, could you share your sample use-cases of mergeGraphqlTypes? It might be useful for another feature that I'm planning to introduce very soon.

from graphql.

michaelbromley avatar michaelbromley commented on March 29, 2024

Sure, here's my use-case (this is prior to Apollo Server v2 migration, so using the old style):

https://github.com/vendure-ecommerce/vendure/blob/7f35f10a12392558decd3c285988113aa37ab175/server/src/app.module.ts#L91-L104

    private createSchema(customFields: CustomFields) {
        const typeDefs = this.graphQLFactory.mergeTypesByPaths(__dirname + '/**/*.graphql');
        const extendedTypeDefs = addGraphQLCustomFields(typeDefs, customFields);
        return this.graphQLFactory.createSchema({
            typeDefs: extendedTypeDefs,
            resolverValidationOptions: {
                requireResolversForResolveType: false,
            },
            resolvers: {
                JSON: GraphQLJSON,
                DateTime: GraphQLDateTime,
            },
        });
    }

The addGraphQLCustomFields() function is internally using graphql-js's extendSchema function to extend the existing objects with new fields according to user config. Implementation is here.

@matcic thanks - that's pretty much exactly what I've got at the moment ;)

from graphql.

matcic avatar matcic commented on March 29, 2024

@kamilmysliwiec my use-case is related to microservices: the idea is to have one schema per microservice (which in turn is generated by merging together several types belonging to different models) and then to merge all schemas into one. I am using Graphql bindings behind the scenes in order to delegate requests to the appropriate endpoint.
I am actually in the process of designing such architecture with a special focus on user authorization - I am pre-processing all resolvers as well in order to create some permission wrappers that can be applied through graphql-middleware. I am afraid I cannot share a complete implementation yet, but I'd be interested in knowing more about the feature you are planning to introduce 😄

from graphql.

lock avatar lock commented on March 29, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.