Code Monkey home page Code Monkey logo

Comments (5)

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024 2

This should be partially fixed in this PR #2969

from graphql.

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024

Would you like to create a PR for this issue?

from graphql.

victorandree avatar victorandree commented on April 28, 2024

@kamilmysliwiec Sure. I couldn't easily figure out how options are eventually passed to the relevant graphql-is functions though. Since simply overriding the type doesn't seem to work, there seems to be some filtering/indirection going on?

If you could point me in a direction, I could definitely do a PR.

from graphql.

rvitaliy avatar rvitaliy commented on April 28, 2024

i have a similar issue but in my case i use class with @ArgsType & @Field to define arguments.

minimal code to reproduce the problem:

import {
  Args,
  ArgsType,
  Field,
  Mutation,
  Resolver,
  ReturnTypeFuncValue,
} from '@nestjs/graphql';

@ArgsType()
class EditServiceArgs {
  @Field({
    deprecationReason: 'This field is deprecated!',
  })
  readonly id: string;

  constructor(id: string) {
    this.id = id;
  }
}

@Resolver()
export class UpdateServiceResolver {
  @Mutation((): ReturnTypeFuncValue => Boolean)
  async updateService(
    @Args() editServiceArgs: EditServiceArgs,
  ): Promise<boolean> {
    // eslint-disable-next-line no-console
    console.log(editServiceArgs);
    // ...do magic with editServiceArgs...

    return true;
  }
}

current generated schema:

updateService(id: String!): Boolean!

expected generated schema:

updateService(id: String! @deprecated(reason: "This field is deprecated!")): Boolean!

extra details:

"@apollo/server": "^4.9.5",
"@nestjs/graphql": "12.0.9",
"graphql": "^16.8.1",


"nodejs": "20.9.0",

from graphql.

j3bb9z avatar j3bb9z commented on April 28, 2024

@kamilmysliwiec I tried doing it just as @rvitaliy, but for me it still doesn't work.

Did anyone here got it working?

from graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.