Add OnSafeEvent about event-emitter HOT 7 CLOSED

So you're basically proposing a no-op on errors for event handlers.

What about adding a new option to the OnEvent instead. Both aren't that flexible tho...

from event-emitter.

yes. I didn't know about that flag

from event-emitter.

@koreanddinghwan the docs is missing that feature as well

feel free to open a PR to update it https://docs.nestjs.com/techniques/events

got it, i'm not good at open-source contribute, and it will be the first time, but i'll gonna try it, thank you for your help!

from event-emitter.

So you're basically proposing a no-op on errors for event handlers.

What about adding a new option to the OnEvent instead. Both aren't that flexible tho...

import { OnOptions } from 'eventemitter2';
export declare type OnEventOptions = OnOptions & {
    prependListener?: boolean;
    suppressErrors?: boolean;
};

is suppressErrors do the samething as i suggested?

from event-emitter.

thank you,
in korea, i saw a blog about 'when event handler do not catch exception, server stops with runtime error'

blogs

but, i cannot reproduce that behavior.

or, somewhere in

i've already make 'onSafeEvent' decorator in my project, but... should it needed?

i think that if we wanna log eventHandler's exception , then use the custom decorator is fine.

oh, i found PR #936 , the blogs is too old, thank you!

from event-emitter.

@koreanddinghwan the docs is missing that feature as well

feel free to open a PR to update it https://docs.nestjs.com/techniques/events

from event-emitter.

nestjs/docs.nestjs.com#2888

from event-emitter.