Code Monkey home page Code Monkey logo

Comments (3)

kamilmysliwiec avatar kamilmysliwiec commented on May 5, 2024 3

you obviously just get the value as a string. But when providing a "generic" type

This "generic" type is wiped out after the compilation. The following line of code:

config.get<number>("PORT");

will be eventually transpiled to a vanilla JavaScript:

config.get("PORT");

Hence, we can't inter what type you expect at runtime.

At this stage, I'd say it'd be nice to have an option added to the get() function, say something like below which would cast to a number before returning.

@prateekkathal you should use custom configuration files for this

from config.

prateekkathal avatar prateekkathal commented on May 5, 2024

@matthiashermsen Thanks for the request.

I feel this is something subjective to the use case. Typescript is still evolving and sometimes, some declarations will state you to use a string PORT value than a number.

Also, the generics are meant for the purpose of declaration and not definition. At this stage, I'd say it'd be nice to have an option added to the get() function, say something like below which would cast to a number before returning.

.get("PORT", { castTo: "number" })

However, I'd leave the final decision on @kamilmysliwiec.

Thanks again!

from config.

matthiashermsen avatar matthiashermsen commented on May 5, 2024

Thanks to your reply :) I think you are right. But I was expecting something like this:
When calling

config.get("PORT");

you obviously just get the value as a string. But when providing a "generic" type

config.get<number>("PORT");

then you explicitly want to cast the value before returning it. But yeah, this is just a suggestion and my personal opinion :)

from config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.