Migrate/Fix/Rethink `NodeIdentityConverterAspect` for 9.0 about neos-development-collection HOT 5 OPEN

we rely on Neos\Flow\Persistence\AbstractPersistenceManager->convertObjectToIdentityArray in some low level places, think you have a node in a Scope("session") object or so. That method can only convert ORM objects though so the aspect wraps around and converts nodes itself into something that can later be unserialized. A serialized NodeAddress shoudl be fine I think.

from neos-development-collection.

and converts nodes itself into something that can later be unserialized. A serialized NodeAddress shoudl be fine I think.

... but we dont support string nodeaddress to node in the long run? #4873

from neos-development-collection.

so it was for holding a Node in a session?

like

/**
 * @Flow\Scope("session")
 */
class MySessionThing {
        protected Node $myNode = null;

        public function setNode(Node $item) {
                $this->myNode = $item;
        }

        public function getMyNode() {
                return $this->items;
        }
}

in Neos 9 id say one must use:

/**
 * @Flow\Scope("session")
 */
class MySessionThing {
        protected NodeAddress $myNode = null;

        public function setNode(NodeAddress $item) {
                $this->myNode = $item;
        }

        public function getMyNode() {
                return $this->items;
        }
}

from neos-development-collection.

well ... as we relaxed our decision over at #4873 (comment) and it looks like well keep a node property mapper, we should probably keep this hack as well ... and make sure that it works.

Imo for that we have to return the node address as string directly and NOT in an array as value of contextPath!

from neos-development-collection.

Christian and me concluded that for routing nodes this is not necessarily required as we currently and will ever serialise the NodeAddress manually. If passed as instance we could confirm that __contextPath will be part of the uri.
Also this logic is needed for forwarding requests and serialising for that all arguments.

from neos-development-collection.