Code Monkey home page Code Monkey logo

Comments (3)

neo-technology-build-agent avatar neo-technology-build-agent commented on August 22, 2024

Comment by jexp
Thursday Oct 20, 2016 at 18:35 GMT


But if you supply a label filter do you just want to a exclude a few?

Perhaps we can do a +* or -* to control if it is blacklist or whitelist by default?

from apoc.

neo-technology-build-agent avatar neo-technology-build-agent commented on August 22, 2024

Comment by InverseFalcon
Thursday Mar 16, 2017 at 01:17 GMT


I'm guessing that this was submitted with the assumption that the labelFilter supports multiple operations at once (+, -, /) instead of only one at a time.

Currently the label filter only allows one operation, the one specified on the very first label of the filter.

This means for a blacklist filter, anything not in the blacklist is allowed, and for the end node label filter, anything not in the end node filter is allowed as a component of a path leading up to an end node, but will never be the end node of a returned path.

#317 is a proposed improvement to allow multiple operations in the filter at once, and addresses the idea that if using an end-node label filter or a blacklist label filter (either alone or in combination with each other), that an empty whitelist should be interpreted as allowing all instead of disallowing all.

Otherwise, if there is a non-empty whitelist label filter, it should probably still exclude any nodes not in the whitelist.

There is still some question regarding the order of evaluation for all three types of filters. If we decide, for example, that the end-node label filter should evaluate before the whitelist, then a node with a label in the end-node label filter should be included even if that label is not in the whitelist, as the whitelist won't have a chance to evaluate it.

There is still ambiguity regarding multi-labeled nodes where its labels fall within multiple label filters, that's up for discussion in #317 .

from apoc.

neo-technology-build-agent avatar neo-technology-build-agent commented on August 22, 2024

Comment by InverseFalcon
Tuesday Mar 21, 2017 at 01:23 GMT


To summarize, I don't think this is a real issue in current implementation, and the concern is being addressed in the work done on allowing multiple label filter operations instead of just one.

Recommending closing this issue.

from apoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.