Code Monkey home page Code Monkey logo

Comments (2)

roman-khimov avatar roman-khimov commented on August 16, 2024 1

I'd say that semantically it's pretty close to https://github.com/neo-project/proposals/blob/master/nep-11.mediawiki#ownerof-1 (accepts token ID, returns an iterator related to it) for which we have

The parameter tokenId SHOULD be a valid NFT ID (64 or less bytes long). If not, this method SHOULD throw an exception.

specified. So exception itself is likely OK here, at least it follows NEP-11 conventions. But this exception should be meaningful of course, "invalid format" or "invalid conversion" are hard to decipher.

from non-native-contracts.

AnnaShaleva avatar AnnaShaleva commented on August 16, 2024

Just for the record: https://github.com/neo-project/non-native-contracts/pull/25/files#diff-d92adeab89009d989ac782ad3056dc68aee0e88547e4f101f95764030d2f0410R660 contains fix for this particular issue along with a set of other improvements.

from non-native-contracts.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.