Code Monkey home page Code Monkey logo

Comments (17)

sergeushenecz avatar sergeushenecz commented on May 27, 2024 14

@NekR Hello. Are we planning to upgrade to webpack 5?

from offline-plugin.

sergeushenecz avatar sergeushenecz commented on May 27, 2024 8

Does it mean the plugin is dead? Maybe Are there alternative plugins?

from offline-plugin.

Enase avatar Enase commented on May 27, 2024 5

The last release was done about two years ago. I don't believe that we find any help here.

from offline-plugin.

 avatar commented on May 27, 2024 3

Hello again guys !
Our team forked and worked on a relase candidate that work with Webpack 5, it's available here => https://www.npmjs.com/package/@lcdp/offline-plugin

Any feedback are welcome, we need you to improve the compatibility with webpack 5 !

from offline-plugin.

Enase avatar Enase commented on May 27, 2024

the same issue for me.
Some more details:
result.resource is undefined.
It can be accessed at result.createData.resource but then the following:

Uncaught exception: Error: NormalModuleFactory.afterResolve is no longer a waterfall hook, but a bailing hook instead. Do not return the passed object, but modify it instead. Returning false will ignore the request and results in no module created.

from offline-plugin.

sergeushenecz avatar sergeushenecz commented on May 27, 2024

@Enase I found an issue webpack/webpack#11647 The same problem. I think plugin not supported the new version webpack.

from offline-plugin.

Enase avatar Enase commented on May 27, 2024

@sergeu90 ic, it's true. thanks.

from offline-plugin.

sergeushenecz avatar sergeushenecz commented on May 27, 2024

Can anyone have experience writing a plugin for webpack? Maybe anyone fork and rewrite this library

from offline-plugin.

gowrav-scienaptic avatar gowrav-scienaptic commented on May 27, 2024

https://developers.google.com/web/tools/workbox/modules/workbox-webpack-plugin

from offline-plugin.

sergeushenecz avatar sergeushenecz commented on May 27, 2024

@gowrav-scienaptic Can you explain? Is it alternative plugin?

from offline-plugin.

gowrav-scienaptic avatar gowrav-scienaptic commented on May 27, 2024

@sergeu90, Yes it's an alternative for offline-plugin. You can read the details on how to integrate here.

from offline-plugin.

timminata avatar timminata commented on May 27, 2024

We are using offline-plugin and attempting to upgrade to Webpack 5. Should we wait for this issue to be resolved or is this no longer maintained?

from offline-plugin.

Enase avatar Enase commented on May 27, 2024

@timminata plugin author doesn't reply over two years. Unfortunately, the answer is yes.

from offline-plugin.

sergeushenecz avatar sergeushenecz commented on May 27, 2024

@gowrav-scienaptic Thanks. I migrated to workbox.

from offline-plugin.

 avatar commented on May 27, 2024

Hello guys !
Our team needs offline-plugin to work with Webpack 5, so we worked on a fix here : #498

Enjoy :)
LCDP,

from offline-plugin.

Enase avatar Enase commented on May 27, 2024

@LeComptoirDesPharmacies Unfortunately it's not possible to create issue in your github repo.
There is an issue while webpack build with your implementation:

(node:18736) [DEP_WEBPACK_COMPILATION_CACHE] DeprecationWarning: Compilation.cache was removed in favor of Compilation.getCache()
    at compilationFn (......./node_modules/@lcdp/offline-plugin/lib/service-worker.js:142:25)
    at _next36 (eval at create (......../node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:50:1)
    at _next14 (eval at create (......../node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:97:1)

and

BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
	Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
	Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    at ServiceWorker.apply (....../node_modules/@lcdp/offline-plugin/lib/service-worker.js:192:35)

from offline-plugin.

 avatar commented on May 27, 2024

@Enase Sorry for this, we have enabled the issues on our repo.

Thank you for your feedback, as we use webpack 5 in production we should fix this depreciation warning before it becomes really breaking.

Do it break your build ?

We have the same warning, but everything works like a charm.

If you see others warnings, don't hesitate to open an issue on our repo, know it's working 💯

Yours faithfully,
LCDP

from offline-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.