Code Monkey home page Code Monkey logo

Comments (6)

stgeke avatar stgeke commented on June 16, 2024

I think we don't need all three as they exercise all the same parts of the code. To obtain a good code coverage, we need to add other tests.

from nek5000.

maxhutch avatar maxhutch commented on June 16, 2024

Benard and eddy are different (forced vs not; scalar vs not). We can remove kovasznay. Do you have suggestions for additions (from nek_examples)?

from nek5000.

stgeke avatar stgeke commented on June 16, 2024

For me a short_test is:

  • serial runtime < 1-2min
  • size < 500K
  • workflow and test answer is fully automated
  • improves code (feature) coverage

The following existing nek/examples come to mind:

  • eddy
  • kov
  • benard
  • lowMach
  • var_vis
  • mv_cyl
  • axi
    May be there are more, but I guess that¹s a good starting point.

@RonRahaman What needs to be done to run all these tests for every push?

from nek5000.

RonRahaman avatar RonRahaman commented on June 16, 2024

@stgeke, here is what needs to be done. I'll start on all of these today:

  • Copy those examples from NekExamples into Nek5000/short_tests
  • Copy the NekTests.py script and libraries from NekExamples to Nek5000/short_tests
  • Edit the .travis.yml file to run these tests in Travis

This will allow those tests to be run for every pull request.

You can also set up your own Travis account to run the tests every time you push to your fork. See steps 1 and 2 here: https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI%3A

from nek5000.

RonRahaman avatar RonRahaman commented on June 16, 2024

@stgeke, which benard test cases did you want to do? There are several .rea files we can run

from nek5000.

RonRahaman avatar RonRahaman commented on June 16, 2024

Closed in #41

from nek5000.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.