Comments (6)
I think we don't need all three as they exercise all the same parts of the code. To obtain a good code coverage, we need to add other tests.
from nek5000.
Benard and eddy are different (forced vs not; scalar vs not). We can remove kovasznay. Do you have suggestions for additions (from nek_examples
)?
from nek5000.
For me a short_test is:
- serial runtime < 1-2min
- size < 500K
- workflow and test answer is fully automated
- improves code (feature) coverage
The following existing nek/examples come to mind:
- eddy
- kov
- benard
- lowMach
- var_vis
- mv_cyl
- axi
May be there are more, but I guess that¹s a good starting point.
@RonRahaman What needs to be done to run all these tests for every push?
from nek5000.
@stgeke, here is what needs to be done. I'll start on all of these today:
- Copy those examples from NekExamples into Nek5000/short_tests
- Copy the NekTests.py script and libraries from NekExamples to Nek5000/short_tests
- Edit the .travis.yml file to run these tests in Travis
This will allow those tests to be run for every pull request.
You can also set up your own Travis account to run the tests every time you push to your fork. See steps 1 and 2 here: https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI%3A
from nek5000.
@stgeke, which benard test cases did you want to do? There are several .rea files we can run
from nek5000.
Closed in #41
from nek5000.
Related Issues (20)
- error on nekbmpi HOT 3
- Working directory changed: can break extension code and .usr code HOT 1
- re2torea: need an check to detect input filename = output filename
- gmsh2nek is creating #v002 .re2 file HOT 5
- Correct boolean statement
- distf integer overflow
- what is the difference between Nek5000 and Nektar++ HOT 1
- ioinfo not working HOT 1
- missing rans_wallfunctions.f file HOT 1
- MHD with stress form
- Issue with 'elmap' corruption in field files of a simulation HOT 2
- ERROR: Error opening file in mfo_open_files. ierr=*** HOT 3
- gmsh2nek failed to work with genmap, created broken .re2 file HOT 2
- Nek5000 new version generating incompatible mesh
- ld error when compiling nek5000 on macOS Sonoma ARM HOT 1
- parRSB/gslib fail to update properly
- sh condition missing in BCDICT
- Pressure solve does not converge for ARM macs using Xcode command line tools >= v15.0
- exo2nek missing boundary while dealing with Tetra+Wedge from ICEM
- DOFs assembly (gathering) on GPU ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nek5000.