Code Monkey home page Code Monkey logo

Comments (7)

neanias avatar neanias commented on July 26, 2024 1

Hi, as an update to this one. If you want to override the highlight groups that Lspsaga uses, you can now do so using the on_highlights config option!

from everforest-nvim.

neanias avatar neanias commented on July 26, 2024

Thanks for the feedback! I've noticed this on my own setup too. Which theme is the bottom screenshot?

from everforest-nvim.

limitLiu avatar limitLiu commented on July 26, 2024

Thanks for the feedback! I've noticed this on my own setup too. Which theme is the bottom screenshot?

Hello, the theme of the bottom screenshot is catppuccin.

from everforest-nvim.

neanias avatar neanias commented on July 26, 2024

I've found what the issue is: Lspsaga uses the Diagnostic text highlights (DiagnosticError, DiagnosticWarn, etc.) for the border when diagnostic.border_follow is set to true (the default). In Everforest, these text highlights all have undercurls. There's 2 options, really:

  1. Set diagnostic.border_follow to be false in your Lspsaga configuration, or
  2. The Diagnostic text highlights are changed to remove the undercurl or are disconnected from the {Error,Warning,Info,Hint}Text highlights.

I've had a look at Catppuccin and Tokyo Night and both of them have independent Diagnostic highlights that don't link to other highlights, so it might be worth breaking from the main Everforest theme in this instance.

from everforest-nvim.

neanias avatar neanias commented on July 26, 2024

I've done some more reading and found the maintainers of Sonokai were also reported this problem and recommended the diagnostic.border_follow = false fix over changing the actual colourscheme to accommodate one plugin, which I agree with. See sainnhe/sonokai#87 for further info.

from everforest-nvim.

limitLiu avatar limitLiu commented on July 26, 2024

I've done some more reading and found the maintainers of Sonokai were also reported this problem and recommended the diagnostic.border_follow = false fix over changing the actual colourscheme to accommodate one plugin, which I agree with. See sainnhe/sonokai#87 for further info.

Yeah, I think u are right.

from everforest-nvim.

limitLiu avatar limitLiu commented on July 26, 2024

Hi, as an update to this one. If you want to override the highlight groups that Lspsaga uses, you can now do so using the on_highlights config option!

Thank u for your updates and reply.

from everforest-nvim.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.