This is <a class="issue-link js-issue-link" data-error-text="F

Thanks for the diff <a class="user-mention notranslate" data-hovercard-type="user" dat

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Ping <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url

Thanks, published <a href="https://hackage.haskell.org/package/fix-whitespace-0.0.10"

Symlink treated as directory,about ndmitchell/filepattern

ndmitchell commented on May 6, 2024 1

Thanks for the diff @andreasabel - unfortunately you've caught me as I'm travelling and otherwise unavailable. Hopefully will take a proper look at this tomorrow.

from filepattern.

ndmitchell commented on May 6, 2024 1

@andreasabel 0.1.3 now released with this fix

from filepattern.

andreasabel commented on May 6, 2024

Relevant code:

filepattern/src/System/FilePattern/Directory.hs

Lines 94 to 101 in 1fe716c

    
           isFile <- whenMaybe (stepDone yes /= [] && stepDone no == []) (doesFileExist path) 
        
           case isFile of 
        
               Just True -> pure [parts ++ x] 
        
               _ | StepEverything <- stepNext no -> pure [] 
        
                 | StepOnly [] <- stepNext yes -> pure [] 
        
                 | otherwise -> do 
        
                   b <- if doesExist && isFile == Just False then pure True else doesDirectoryExist path 
        
                   if not b then pure [] else f (parts ++ x ++ "/") yes no

In

filepattern/src/System/FilePattern/Directory.hs

Line 100 in 1fe716c

    
           b <- if doesExist && isFile == Just False then pure True else doesDirectoryExist path

we get isFile == Just False for a symlink, which is then treated as directory.
The docs for doesFileExist are misleading (outright wrong):
https://hackage.haskell.org/package/directory-1.3.7.1/docs/System-Directory.html#v:doesFileExist

The operation doesFileExist returns True if the argument file exists and is not a directory, and False otherwise.

from filepattern.

andreasabel commented on May 6, 2024

Since if doesExist && isFile == Just False then pure True isn't working for symlinks, we need to check doesDirectoryExist anyway, thus can get rid of the doesExist optimization altogether. Implemented in:

#6

from filepattern.

andreasabel commented on May 6, 2024

Ping @ndmitchell.

from filepattern.

andreasabel commented on May 6, 2024

Thanks for merging! Please ping me when you release, so I can depend on the latest version.

from filepattern.

andreasabel commented on May 6, 2024

Thanks, published https://hackage.haskell.org/package/fix-whitespace-0.0.10.

from filepattern.

Symlink treated as directory about filepattern HOT 7 CLOSED

Comments (7)

Related Issues (5)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	isFile <- whenMaybe (stepDone yes /= [] && stepDone no == []) (doesFileExist path)
	case isFile of
	Just True -> pure [parts ++ x]
	_ \| StepEverything <- stepNext no -> pure []
	\| StepOnly [] <- stepNext yes -> pure []
	\| otherwise -> do
	b <- if doesExist && isFile == Just False then pure True else doesDirectoryExist path
	if not b then pure [] else f (parts ++ x ++ "/") yes no