Comments (2)
Thanks for the report.
-
I am expecting all git SHA1's to be the full 40 element hash, and expecting that if people want short SHA1 options they will do it themselves as a wrapper script on top. In my implementation we have something that resolves using
git rev-parse
, defaulting toHEAD
if nothing is specified. I could allow shorter hashes, but I'd prefer to always work with full hashes in the app and shorter hashes outside. That said, I'm on the fence as to whether to allow shorter hashes or not. -
Retry doesn't work for identical patch names, so I prepend a
'
to them. Using theovenPretty
helper you write something likeneil=ccc...
(whereneil
is the branch name), and then retry makes it'neil=ccc...
, which is still valid. Dropping leading'
from the sha1 seems like the right thing to do.
So both of these could be fixed, and the second almost certainly should, but both are easily worked around.
from bake.
I changed the docs, and your code in #17 and #18 fixed the other, so this is all now sorted.
from bake.
Related Issues (20)
- Support much bigger files HOT 1
- Notifications on clients coming/going are missing HOT 1
- Include patch author in the emails HOT 1
- Client crashes due to error 500 when finishing HOT 15
- Bake client process is too CPU heavy HOT 1
- Don't send emails until after updating the state
- Merged summary issues are in the wrong order
- Code is built twice HOT 6
- Build output disappears HOT 3
- How to run tests in parallel with multiple clients? HOT 13
- Add -K1K to the test suite
- How do I use `bake gc` ? HOT 4
- GC should not remove data from latest incremental build
- Using 'Retry' in admin view adds a quote to patch number preventing it to be merged HOT 2
- Bring up clients as needed? (assuming clients are virtualized) HOT 7
- Problems building on ghc-7.8.4 HOT 6
- Document all functions HOT 4
- Build failure with extra-1.5.1 HOT 1
- Support multiple Git repositories from a single server? HOT 1
- bake-0.5 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bake.