Code Monkey home page Code Monkey logo

Comments (2)

ndmitchell avatar ndmitchell commented on May 5, 2024

Thanks for the report.

  1. I am expecting all git SHA1's to be the full 40 element hash, and expecting that if people want short SHA1 options they will do it themselves as a wrapper script on top. In my implementation we have something that resolves using git rev-parse, defaulting to HEAD if nothing is specified. I could allow shorter hashes, but I'd prefer to always work with full hashes in the app and shorter hashes outside. That said, I'm on the fence as to whether to allow shorter hashes or not.

  2. Retry doesn't work for identical patch names, so I prepend a ' to them. Using the ovenPretty helper you write something like neil=ccc... (where neil is the branch name), and then retry makes it 'neil=ccc..., which is still valid. Dropping leading ' from the sha1 seems like the right thing to do.

So both of these could be fixed, and the second almost certainly should, but both are easily worked around.

from bake.

ndmitchell avatar ndmitchell commented on May 5, 2024

I changed the docs, and your code in #17 and #18 fixed the other, so this is all now sorted.

from bake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.