Code Monkey home page Code Monkey logo

Comments (3)

hfat avatar hfat commented on June 5, 2024

Thanks for fixing this bug.
But shouldn't the library ideally retrieve the correct sum and check it? Or verify each segment before assembling the file?

Disabling the check would of course be better than the current behavior but if retrieving the correct sum(s) isn't possible, perhaps the user should be notified (for instance with a non-fatal error). The expectation would naturally be that that the software has verified the sum upon completion of the download since that's what it does with other files.
Or if the verification is basically useless to begin with, pehaps it should be disabled by default so as not to waste resources and induce a false sense of security.

from swift.

ncw avatar ncw commented on June 5, 2024

@hfat Unfortunately it isn't possible to retreive the MD5SUM for a chunked file. You can get the MD5SUM of the MD5SUMs of the individual segments. However that isn't at all easy to calculate for the receiver, so my preference is to just ignore the check for big files. The library has been doing that for Dynamic large objects for some time, it just needs a tweak to do the same thing for static large objects.

from swift.

hfat avatar hfat commented on June 5, 2024

In case you mention that in the documentation, note that it's not only big files that are affected but (at least with Hubic's official Linux client) all segmented files, which can be quite small.

from swift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.