Code Monkey home page Code Monkey logo

Comments (6)

benjaminEwhite avatar benjaminEwhite commented on May 29, 2024

@SchaeStewart can you provide more detail on this one. Is the idea that this endpoint allows you to search for a pac, donor, and candidate all in one request?

from campaignfinance.

SchaeStewart avatar SchaeStewart commented on May 29, 2024

Yes that's the idea. If you look at the wireframe, the initial search bar, searches all of those data types. https://www.figma.com/proto/OcC48DWJjwCsPigGa9vb82/Campaign-Finance-Dashboard-Wireframes?node-id=2%3A59&viewport=-1320%2C-986%2C0.3811715841293335&scaling=scale-down-width

from campaignfinance.

benjaminEwhite avatar benjaminEwhite commented on May 29, 2024

@SchaeStewart not totally obvious to me how this endpoint should handle pagination given that it's stitching together 3 types of entities.

One way we might do this is like this:

{
  "data": 
    {
      "type": "candidate",
      "content": {
        "candidate_last_name": "ABERNETHY",
        "candidate_first_name": "RICHARD",
        "candidate_middle_name": "BRUCE",
      }
    },
    {
      "type": "donor",
      "content": {
        "id": "<some-id>",
        "name": "Adam Apple",
        "city": "city",
        "state": "NC",
        "zip_code": "27103",
        "profession": "PHYSICIAN",
        "employer_name": "NOVANT HEALTH UROLOGY PARTNERS",
        "sml": 0.6875
      }
      ...
    }
  ],
  "count": "some value"
}

Thoughts?

from campaignfinance.

SchaeStewart avatar SchaeStewart commented on May 29, 2024

I think we can probably skip the pagination for this route and just limit the results. My thought is, this endpoint will support getting the table data in this view: https://www.figma.com/proto/OcC48DWJjwCsPigGa9vb82/Campaign-Finance-Dashboard-Wireframes?node-id=2%3A277&viewport=-1320%2C-986%2C0.3811715841293335&scaling=scale-down-width

If the user wants to go past to first page of results, we should probably just push them to the page they are interested in. For example, if they are looking at the candidates tab, and they want to see more candidates, we would just redirect them to a candidates page

from campaignfinance.

SchaeStewart avatar SchaeStewart commented on May 29, 2024

Did you want me to assign this one to you?

from campaignfinance.

benjaminEwhite avatar benjaminEwhite commented on May 29, 2024

Yeah i can do this one.

from campaignfinance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.