Code Monkey home page Code Monkey logo

Comments (6)

ncabatoff avatar ncabatoff commented on August 26, 2024

Sorry @flixr, I let this one slip by me. I'll try to get to it next week.

from process-exporter.

flixr avatar flixr commented on August 26, 2024

The simple numThreads (without status as per #17) is already available in prometheus/procfs

from process-exporter.

ncabatoff avatar ncabatoff commented on August 26, 2024

Thanks for the PR. I'm going to hold off on merging it until we decide what to do about #19 and #17, since it may make this redundant.

from process-exporter.

flixr avatar flixr commented on August 26, 2024

I first thought so as well, but I now think this would make sense in any case as it doesn't cost more and #19 would probably be configurable for only some processes. (And #17 is basically a subset of #19)

from process-exporter.

ncabatoff avatar ncabatoff commented on August 26, 2024

#17 need not be a subset of #19, as described it was going to give a count of how many threads are in which state. I agree that given #19 it may make more sense to report these counts on the more granular per-threadname basis it will introduce, but I haven't fully made up my mind. I think I might want the #17 metrics for my primary use case, where I may not be able to tolerate the huge increase in metric count that the #19 threaded-mode will bring in. Then again, with the huge resource savings Prometheus 2 will bring, maybe I shouldn't be worrying so much about the number of metrics.

from process-exporter.

ncabatoff avatar ncabatoff commented on August 26, 2024

I thought about it some more and I decided that as you say it's a useful metric and adding this doesn't require any extra files so it's cheap. And some people who don't want the extra overhead of parsing the per-thread files may want this metric.

from process-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.