Code Monkey home page Code Monkey logo

Comments (5)

ScaldedWilder avatar ScaldedWilder commented on June 2, 2024 2

The opening issue (secondary genra LofiGirl not being correctly filtered out) existed in 0.49.3, but I just lived with it, figuring I'd done something wrong. After I upgraded and it persisted, I finally decided to debug some and file this issue.

I'd recommend filing separate issues for the genre bugs you've experienced that's new in 0.50.X

from navidrome.

ScaldedWilder avatar ScaldedWilder commented on June 2, 2024 1

I've tested this more, to try and narrow this down more.

It seems like it's possible 'does not contain' may only be getting applied correctly if there is only one genre.

A good test is using something like

  • Contains: Alt
  • Contains Rock
    gives me entries with genres like:
  • Alternative Rock
  • Pop Punk, Alternative rock, Rock

but

  • Contains: Alt
  • does not contain: Rock
    yields songs with genres like:
  • Alternative Metal, Rock, Alternative Rock
  • Alternative Rock, Alternative Metal
  • Alternative & Punk
  • Alternative
    But I don't see any single genre songs with 'Rock' in the result

So I believe the reduced/core symptom is that 'Does not contain' appears to only correctly apply if there is a single genre. If there are multiple genres, even matching the first genre (e.g. Rock, Alternative) seems insufficient for smart playlists to omit the song.

from navidrome.

metalheim avatar metalheim commented on June 2, 2024

Can confirm this behaviour.
"genre isNot X" or "genre notContains X" only filters out tracks that have this genre X and only X
As soon as a track has multiple genres, this filter kinda becomes useless.

My guess is that this filter just translates to filtering the media_file_genres table and then grouping them by song again.

from navidrome.

mneuburg-livefront avatar mneuburg-livefront commented on June 2, 2024

But I've seen some other genre-related weirdness related to the 0.50.x versions. I had to go back to 0.49.3 to work around this. Something changed here.

from navidrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.