Code Monkey home page Code Monkey logo

Comments (7)

cianmcgrath avatar cianmcgrath commented on September 24, 2024 1

Yes we are actively trying to resolve the imports issue you've raised and work our way forward with something more stable/less prone to package name collisions. It requires coordination between several internal teams though as there are a number of layers of automation involved in the release pipeline, so there might not be a satisfactory resolution in the short term, but we are working on it.
1.5.0 also had to be yanked earlier on due to an issue with the release pipeline, so it is equivalent to 1.4.2 I think. 1.4.3+ have features/fixes not incorporated, including for the issue here
Apologies for interference with your your projects anyways, and thanks for raising the problem

from nautobot-plugin-ssot-arista-cloudvision.

jdrew82 avatar jdrew82 commented on September 24, 2024

This has been determined to be an issue within the cloudvision-python package and their imports. The project structure is wrong and there formats aren't using the project root in the path. This is allowing for the actual fmp project which was created in Apr 2022 to conflict and thus cause the error. This needs to be fixed in the cloudvision-python package. Ref aristanetworks/cloudvision-python#7

from nautobot-plugin-ssot-arista-cloudvision.

cianmcgrath avatar cianmcgrath commented on September 24, 2024

What version of the package is installed?
I believe that this issue was resolved in this change, so updating to v.1.4.3+ should resolve this

from nautobot-plugin-ssot-arista-cloudvision.

jdrew82 avatar jdrew82 commented on September 24, 2024

This was using the latest version of cloudvision-python. I've specifically pointed out the issue in your project @cianmcgrath. You need to update your imports in your project to include the project name. Otherwise, you're allowing for other public packages like the fmp one to override. It is very obvious when you look at the file paths and the import statements.

from nautobot-plugin-ssot-arista-cloudvision.

cianmcgrath avatar cianmcgrath commented on September 24, 2024

It's not up to date though
import wrappers_pb2 as wrappers is only in version 1.4.2 or before as the change I linked (which is a part of v1.4.3+) has import fmp.wrappers_pb2 as wrappers (which we have confirmed does work) and the fmp package on pypi does not have any contents in it's init.py file

This is of course separate to your concern regarding the fmp package as a whole, which I've raised with the relevant teams

from nautobot-plugin-ssot-arista-cloudvision.

jdrew82 avatar jdrew82 commented on September 24, 2024

Poetry specifically is picking 1.5.0 for some reason which is a bit strange since I see that has been yanked from PyPI. I've pinned it to 1.4.4 and tested it. It does appear that the issue is resolved with your tweak to fmp init.py file. I still think you should fix your imports to be more explicit and avoid this in the future. Probably need to figure out why 1.5.0 is still being pinned by Poetry too.

from nautobot-plugin-ssot-arista-cloudvision.

jdrew82 avatar jdrew82 commented on September 24, 2024

@cianmcgrath No worries. Appreciate you working with me to find a resolution and fix it going forward. We appreciate the work Arista has done in creating the library to assist us in creating this app.

from nautobot-plugin-ssot-arista-cloudvision.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.