Inconsistent handling of "no matches found" cases about nautobot-plugin-chatops-meraki HOT 4 CLOSED

thanks @glennmatthews will review this.

from nautobot-plugin-chatops-meraki.

@glennmatthews is there a recommended approach on these? Since the command is successful the data just doesn't exist should it just be a simple markdown message? Or is using one of the CommandStatusChoices the best option.

from nautobot-plugin-chatops-meraki.

Looking at the nautobot command worker in the base nautobot-chatops plugin, it doesn't look like we're even fully self-consistent there. :-(

Off the top of my head, STATUS_FAILED should probably be reserved for cases where there's an error of some sort (e..g the user specified an invalid argument, a REST API call returned a 500 error, etc.), so I think that the case of "you specified valid query inputs, there just wasn't anything that matched" probably should result in STATUS_SUCCESS and an appropriate message to the user. But it might be worth starting a more general discussion on this question.

from nautobot-plugin-chatops-meraki.

Thanks! I'll go that route for now, and get a discussion opened on the nautobot-chatops repo.

from nautobot-plugin-chatops-meraki.