Code Monkey home page Code Monkey logo

Comments (3)

Jarema avatar Jarema commented on June 8, 2024

#4878 seems to be closely related, however the #5384 does not fix that one.

from nats-server.

MauriceVanVeen avatar MauriceVanVeen commented on June 8, 2024

@Jarema have been looking at #4878 as well, and believe it's due to the following code existing when deleting a consumer, but not when updating it:
https://github.com/nats-io/nats-server/blob/main/server/consumer.go#L5225-L5252

If the same logic would be present for the update, but with a slight adjustment to if mset.noInterest(seq, o) (because it ignores the provided consumer), then it should be fixed.

I could work on a PR with a fix for that today, if that's okay? (Although am not sure yet how to handle for the clustered JS case)

from nats-server.

MauriceVanVeen avatar MauriceVanVeen commented on June 8, 2024

Possibly have a fix for #4878, here: #5385

from nats-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.