Describe the bug I use your code with net core 3 preview 6, and t

Btw, I <a href="https://github.com/natemcmaster/DotNetCorePlugins/commit/85a4c87dc6a55

Add Controller from Plugin in .NET Core 3 doesn`t work as expected about dotnetcoreplugins HOT 3 CLOSED

natemcmaster commented on July 30, 2024

Add Controller from Plugin in .NET Core 3 doesn`t work as expected

from dotnetcoreplugins.

Comments (3)

natemcmaster commented on July 30, 2024

Thanks for opening the issue. I'm heading out on a long trip, so won't be able to investigate more right now, but this looks like something that needs more investigation. If you're able to identify what is wrong, I'd appreciate the help.

from dotnetcoreplugins.

natemcmaster commented on July 30, 2024

Btw, I updated my MVC sample to .NET Core 3, and things appear to work just fine. Can you try updating your code to use ApplicationPartFactory instead of AddApplicationPart()? See

DotNetCorePlugins/samples/aspnetcore-mvc/MvcApp/Startup.cs

Lines 14 to 54 in 85a4c87

    
                   public void ConfigureServices(IServiceCollection services) 
        
                   { 
        
                       var mvcBuilder = services 
        
                           .AddMvc() 
        
                           .SetCompatibilityVersion(CompatibilityVersion.Version_3_0); 
        
                       foreach (var dir in Directory.GetDirectories(Path.Combine(AppContext.BaseDirectory, "plugins"))) 
        
                       { 
        
                           var pluginName = Path.GetFileName(dir); 
        
                           var plugin = PluginLoader.CreateFromAssemblyFile( 
        
                               Path.Combine(dir, pluginName + ".dll"), // create a plugin from for the .dll file 
        
                               config => 
        
                                   // this ensures that the version of MVC is shared between this app and the plugin 
        
                                   config.PreferSharedTypes = true); 
        
                           var pluginAssembly = plugin.LoadDefaultAssembly(); 
        
                           Console.WriteLine($"Loading application parts from plugin {pluginName}"); 
        
                           // This loads MVC application parts from plugin assemblies 
        
                           var partFactory = ApplicationPartFactory.GetApplicationPartFactory(pluginAssembly); 
        
                           foreach (var part in partFactory.GetApplicationParts(pluginAssembly)) 
        
                           { 
        
                               Console.WriteLine($"* {part.Name}"); 
        
                               mvcBuilder.PartManager.ApplicationParts.Add(part); 
        
                           } 
        
                           // This piece finds and loads related parts, such as MvcAppPlugin1.Views.dll. 
        
                           var relatedAssembliesAttrs = pluginAssembly.GetCustomAttributes<RelatedAssemblyAttribute>(); 
        
                           foreach (var attr in relatedAssembliesAttrs) 
        
                           { 
        
                               var assembly = plugin.LoadAssembly(attr.AssemblyFileName); 
        
                               partFactory = ApplicationPartFactory.GetApplicationPartFactory(assembly); 
        
                               foreach (var part in partFactory.GetApplicationParts(assembly)) 
        
                               { 
        
                                   Console.WriteLine($"  * {part.Name}"); 
        
                                   mvcBuilder.PartManager.ApplicationParts.Add(part); 
        
                               } 
        
                           } 
        
                       } 
        
                   }

from dotnetcoreplugins.

ThorstenWeiss commented on July 30, 2024

thanks, works fine.

from dotnetcoreplugins.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	public void ConfigureServices(IServiceCollection services)
	{
	var mvcBuilder = services
	.AddMvc()
	.SetCompatibilityVersion(CompatibilityVersion.Version_3_0);

	foreach (var dir in Directory.GetDirectories(Path.Combine(AppContext.BaseDirectory, "plugins")))
	{
	var pluginName = Path.GetFileName(dir);

	var plugin = PluginLoader.CreateFromAssemblyFile(
	Path.Combine(dir, pluginName + ".dll"), // create a plugin from for the .dll file
	config =>
	// this ensures that the version of MVC is shared between this app and the plugin
	config.PreferSharedTypes = true);

	var pluginAssembly = plugin.LoadDefaultAssembly();
	Console.WriteLine($"Loading application parts from plugin {pluginName}");

	// This loads MVC application parts from plugin assemblies
	var partFactory = ApplicationPartFactory.GetApplicationPartFactory(pluginAssembly);
	foreach (var part in partFactory.GetApplicationParts(pluginAssembly))
	{
	Console.WriteLine($"* {part.Name}");
	mvcBuilder.PartManager.ApplicationParts.Add(part);
	}

	// This piece finds and loads related parts, such as MvcAppPlugin1.Views.dll.
	var relatedAssembliesAttrs = pluginAssembly.GetCustomAttributes<RelatedAssemblyAttribute>();
	foreach (var attr in relatedAssembliesAttrs)
	{
	var assembly = plugin.LoadAssembly(attr.AssemblyFileName);
	partFactory = ApplicationPartFactory.GetApplicationPartFactory(assembly);
	foreach (var part in partFactory.GetApplicationParts(assembly))
	{
	Console.WriteLine($" * {part.Name}");
	mvcBuilder.PartManager.ApplicationParts.Add(part);
	}
	}
	}
	}

Comments (3)

Related Issues (20)

Recommend Projects

Recommend Topics

Recommend Org