Rainbow Facets about d2-holy-grail HOT 9 CLOSED

I will think about it.

Maybe I will have a sudden burst of motivation to implement it ;)

from d2-holy-grail.

Actually the fix would be as easy as simply adding the 4 news items / changing the existing ones.
Because displaying the grail (as far as I remember :P) is not based on the actual definition of the files, but on the "instance" of your grail config which is returned from the server / you ahve in the cache.
So I think existing users would not be affected at all. (Which is both good and bad...well in this case good).

I'm just not sure if we should really do that. I had discussions in discord about this already. I personally don't have a strong opinion. But if we do it I just want to be really sure that 8 is correct.... based on your links it is... so maybe you're right. => so imho it can be done.

Concerning the password things:
Yes it's a cheap solution.... I actually never thought people would really use this site at all - but just in case I added the not already in the very beginning ;)

It's also not like I don't know how to secure the app, I just didn't find it necessary until now - and I still don't.
One user actually forgot his PW once and wrote to me in discord... I then reset it ;)
But if you feel strong about this and want to do it... feel free to start working on it / we can also discuss it further :)

from d2-holy-grail.

There's no way for current users to be unaffected ... I assume you mean the site won't break for them, in which case - yes, even if there was an implementation detail that would cause a breakage, that would be easily correctable with a small script to update current data.
However, a person who has marked e.g. a "Cold" faced as owned will now no longer have it marked in their gail list - that's a BC break, hence my suggestion for some kind of a notification.

As for the password-related stuff ... I've never met a developer who doesn't think they can "secure" an app, while in reality most implementations are not up to respectable standards. :) Either way, I guess it's fine as it is now; that was really just an on the side remark as I was thinking of email notifications.

from d2-holy-grail.

No it doesn't have an impact actually :)

I tested it locally.

So that's an old grail locally:

Then I updated the code and created a new grail locally (and yes also if you refresh etc. the old grail is still the same on the other address):

The only thing left to do, would actually be to make the "API" work with the new / old versions.

PS:
Concerning the security. I would never all me an expert. I usually work with .NET Core apps and the way I would secure an app would be by using a "famous" auth framework (like Auth0) or whatever so I don't have to store any PW's at all in my DB and then work with this - roughly :P

from d2-holy-grail.

What? One has to create an entirely new grail to track? That's the least convenient solution for users.

from d2-holy-grail.

Well no.
It's still possible to migrate their holidaygrail (automatically) to the new grail version.
For example we could also define, that if you have checked the jewels on the old version, that on the new version we will just check both level up and die or something like this.

from d2-holy-grail.

And that's where the BC break I was talking about comes into play. :)

Just in the interest of someone not mistakingly having their grail marked as complete by accident, I would suggest to have neither marked and simply display a notification about the change, so users can mark the correct items accordingly.

from d2-holy-grail.

Done & released

check https://d2-holy-grail.herokuapp.com/Nasicus/holy/search?q=facet
for a migrated version

from d2-holy-grail.

Awesome, thanks!

from d2-holy-grail.