Whitespace characters in ApiConfig.api_key cause runtime-errors about data-link-python HOT 2 CLOSED

1.0.1 has been pushed to pypi which should resolve this issue.

However, I'm keeping it open for a bit to collect any more use-cases people may run into. Additionally, there's a bit of code-smell, imo, with respect to the ApiConfig class attribute usage.

At the moment, api_config.py doesn't attempt to strip() the environment var value either: it's possible users could set the env-var where whitespace is passed in, and it's still not addressed. Ideally both methods of finding a user's api key should rely on the same methods to fix unwanted whitespace before being accessed. In other words, we shouldn't have to pepper strip() everywhere, this will just make things harder to maintain in the future.

Ideally ApiConfig should be refactored to be a @dataclass, on instantiation it attempts to find a user's api key in an env-var or in a file, remove unwanted whitespace using the same implementation strategy and move on. It should not be up to the caller (connection.py in this case) to be worrying about and fixing the api key when setting the x-api-token header.

from data-link-python.

Closing as we haven't receiving complaints about this in a while.

from data-link-python.