How to use inline attachments? about cakephp-mailgun HOT 5 CLOSED

Hi. I edited the MailgunTransport class and figured that if you add the line

$this->_attachments['inline'] = $attachments;

after this line, it works.

The problem is that the attachment will be send twice, so it's not a good solution

from cakephp-mailgun.

Sending them twice is not a good idea. I will check what can be done for this.

from cakephp-mailgun.

Hey, @narendravaghela did you check this issue?

Soon i'll need to send inline attachments, so i'll try to fix this issue somehow.
The way i'm thinking to handle this is on:

    if (!empty($attachments)) {
        $this->_attachments['attachment'] = $attachments;
    }

If $attachments' itens have the contentId property, i can shift them from the $attachments into a new variable and then $this->_attachments['inline'] = $inlineAttachments; or something like that.

What do you think?

from cakephp-mailgun.

Hi @alysson-azevedo
Didn't get time to check this plugin, sorry about that :)
I think the plugin needs to be updated in many ways as there is Cake 3.6 out now. I haven't used this plugin for a long time, so need to check for inline attachments. But the proposed solution looks good to me for now.
Also, please generate PRs for the fixes that you have made in this plugin, so others can take benefits.

from cakephp-mailgun.

Ok, i'll look into that.

from cakephp-mailgun.