Code Monkey home page Code Monkey logo

Comments (7)

NikunjKhangwal avatar NikunjKhangwal commented on May 19, 2024 1

Yeah, fair point. You should at least make the info take 2 lines tho since that overlap doesn't look good either.
Also unless i'm missing something, why do you call the main playing screen "miniplayer"? I thought miniplayer was the one that appears when you swipe down the main player (With only back play/pause and previous button). I'm going to create a issue for this and i don't want it to be confusing.

from namida.

NikunjKhangwal avatar NikunjKhangwal commented on May 19, 2024 1

Got it, thanks

from namida.

MSOB7YY avatar MSOB7YY commented on May 19, 2024
  1. investigating
  2. was fixed
  3. not possible, u can swipe to the right a bit to have a peek
  4. maybe its time to reduce font size a bit from Customization Settings, i cant make it take more than 1 line

from namida.

NikunjKhangwal avatar NikunjKhangwal commented on May 19, 2024

Can Confirm, expanded lyrics button doesn't work a lot of times for me as well. Also yes make the audio info take two lines if it's overlapping. You can also move the repeat button above queue button since there's enough empty space along with a new "sleep timer" button above lyrics button. (Was going to make a new feature request for sleep timer button)

from namida.

MSOB7YY avatar MSOB7YY commented on May 19, 2024

@NikunjKhangwal
after investigating, it seems like the issue is caused by scaling the artwork (AnimatedScale) which might not allow touches outside the original size.

im not very sure about workarounds, there isnt any place for this button in the miniplayer ui

about making the info 2 lined, and possibly introduce sleep timer (by making 4 squared icons), it will require some painy refactor and i don't think it will even look good, especially the 4 squared icons

ughhh im not sure yet

from namida.

MSOB7YY avatar MSOB7YY commented on May 19, 2024

okay i will look into that after a while

well to be technically right, its exactly "expanded miniplayer", others could work too like player screen or whatever, its just my view, could be wrong.

u can create the issue with any name u like as long as it's clearly referring to it

from namida.

MSOB7YY avatar MSOB7YY commented on May 19, 2024

with [2031d74], number 1 (enter lrc fullscreen) can be fixed using 2 ways:

  1. since artwork scaling is now possible, u can make it a bit smaller, this will make the button work properly
  2. you can also just pinch in (zoom) when lrc view is displayed, and it will enter fullscreen

unfortunately, the core issue (button should be pressed) doesnt seem to be fixable, since scaling up the artwork doesnt scale the GestureDetector hit test area.

for reference:

  1. flutter/flutter#27587
  2. flutter/flutter#75747

from namida.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.