Comments (6)
N8python
commented on June 12, 2024
Could you fork the repo and implement the remove cat buttons? Then I could review.
from potatoz2.
00f2ff
commented on June 12, 2024
I suggest learning a frontend framework to help you assign values to elements and keep the code tidier. Another thing you'll want to look into is using webpack or similar for import resolution to split the code up. It's going to be tough to add this feature because your code is not external developer-friendly (i.e. missing detailed comments, lack of documentation, etc.), and I don't want to have to learn how the entire codebase works to make the change.
That said, I'll make a PR, but instead of fixing this issue I'll write some helper functions that make your life easier.
from potatoz2.
N8python
commented on June 12, 2024
Thank you. At the time I worked on Potatoz I didn’t know that such a thing as front end frameworks existed, and I wrote REALLY sloppy code. I’ll document it over the weekend to make in easier on external devs.
… On May 3, 2019, at 9:44 PM, Duncan McIsaac ***@***.***> wrote:
I suggest learning a frontend framework to help you assign values to elements and keep the code tidier. Another thing you'll want to look into is using webpack or similar for import resolution to split the code up. It's going to be tough to add this feature because your code is not external developer-friendly (i.e. missing detailed comments, lack of documentation, etc.), and I don't want to have to learn how the entire codebase works to make the change.
That said, I'll make a PR, but instead of fixing this issue I'll write some helper functions that make your life easier.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKKMMKHYWCG4H7U6XJHJY4TPTTS6LANCNFSM4HKXOREQ>.
from potatoz2.
pjlasl
commented on June 12, 2024
I added a + and - with the ability to select an amount. waiting on merge from N8python
from potatoz2.
N8python
commented on June 12, 2024
This issue is nearly resolved - Once pjasl UI is merged, we will have incrementing + decrementing buttons for the cats.
from potatoz2.
N8python
commented on June 12, 2024
I merged pjlasl's pull request. There are now increment + decrement buttons.
from potatoz2.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from potatoz2.