FTP node doesn't seem to create directories about n8n HOT 11 OPEN

So I just tried another test using an empty workflow that just has the one FTP node. Now I get a 550 error. If I create the parent directories beforehand, then the rename works.

from n8n.

Just to again rule out dumb permission problems, I tried just now using an FTP client to upload a file to non-existent directories and it was successful in creating them, so unfortunately it does appear to be n8n not being able to make directories.

from n8n.

I think you have issue with premissions for FTP folder

from n8n.

I had first thought it would be a permission issue within IIS (this is a IIS hosted FTP site), so I have also setup another site using a directory that has full control for everyone and still the same problem. All of the other FTP operations seem to work though.

from n8n.

Hey @evok01,

Thanks for the report, It looks like we never actually tried to use the create option so I have popped in a PR to test it. I don't have an IIS FTP site available for testing but the change works against pure-ftpd, If I create a test docker image from the PR would you be able to test it to see if it works for IIS?

from n8n.

@Joffcom Sure thing

from n8n.

@evok01 perfect thanks, In a test environment if you can use n8nio/n8n:PR-9340-gh-9296 as the image it will contain the fix I have put in.

from n8n.

Hey @evok01,

Have you had a chance to test yet?

from n8n.

@Joffcom I have tested just now and I am seeing an error:

The FTP site that it is connecting to is using a root directory that has full permissions for everyone, and those open permissions are cascaded to all folders and files. It may be some weird config setting that I need to tweak in IIS but this is a new site for the purpose of testing.

Here is the most from the logs that I can see when the rename node is run:

runner-n8n-1  | 2024-05-15T15:46:51.150Z | debug    | Running node "Move installer to Runtime directory" finished successfully "{\n  node: 'Move installer to Runtime directory',\n  workflowId: 'oPOcro84HbvKmlvE',\n  file: 'LoggerProxy.js',\n  function: 'exports.debug'\n}"
runner-n8n-1  | 2024-05-15T15:46:51.150Z | debug    | Executing hook on node "Move installer to Runtime directory" (hookFunctionsPush) "{\n  executionId: '109097578',\n  pushRef: 'lq6e0rmb5h9',\n  workflowId: 'oPOcro84HbvKmlvE',\n  file: 'WorkflowExecuteAdditionalData.js',\n  function: 'nodeExecuteAfter'\n}"

I'll enable any additional logs that I can.

from n8n.

Hey @evok01,

Would you be able to try a workflow that just has the FTP node in it and try to rename a file in there so we can rule out anything else. Can you also make sure the node isn't set to continue on error under the settings.

from n8n.

@evok01 that is perfect, I can fix that. The PR makes the folder if the server returns a 451 error or attempts to which is what my ftp server used as the error code. I will add 550 to it as well and update the image which should solve it for IIS as well.

from n8n.