Comments (14)
Hey @meownoid,
I will take a look at this. It was intentionally changed as the previous version caused a lot of events to be missed so this was the best option.
We did store the current time before and compare that but some feeds published hourly.
from n8n.
@Joffcom hey! Thanks for looking into this! If I'm not mistaken, I think storing the maximum date from the feed (as opposed to the last date or date of execution) should solve the problem, but I might be missing some details here.
from n8n.
Hey @meownoid,
Normally the first entry in a feed should be the newest entry so I am going to dig into why the GitHub feed is out of order and see if there any preference in the RSS spec.
from n8n.
same problem, a lot of duplicates events. temporary disabled problematic feeds
from n8n.
@yrmuq which feed are you using? Typically I would expect the first item in the feed to be the newest which is the case for most feeds but there appears to be a couple that don't want to operate that way so I will need to put in a fix for that.
from n8n.
@Joffcom most duplicates found on this feed. Every x minutes get old duplicates all the time
https://github.com/arichornlover/YouTubeRebornPlus/releases.atom
from n8n.
@yrmuq interesting, it is another GitHub atom feed 🤔
from n8n.
@Joffcom even more interesting, its sends duplicates after it's been deactivated 😃
from n8n.
@yrmuq that doesn't sound right, Are you running in queue mode? It is a polling based workflow so once disabled if it is still running there is either a core bug or a configuration issue like having 2 main instances running.
from n8n.
@Joffcom don't worry, its just a bug, after deleting and re-adding rss node and restarting, now its normaly deactivated)
But what can we do with GitHub atom feed?
from n8n.
Hey @yrmuq,
I think the best option would be to update the node to loop over all of the items to work out what the newest is rather than trusting that the order will be correct.
from n8n.
Now another RSS feed gives me duplicate events, this time not GitHub-related: https://www.ableton.com/en/blog/feeds/latest/.
Is it in the RSS specification that events must be ordered? If yes, then I'm surprised tools that generate those feeds do not adhere to the standard. If not, then I don't understand why n8n makes such an assumption.
from n8n.
Hey @meownoid,
The RSS spec itself doesn't require events to be in order and to make things more interesting the pubDate
is also optional which means a site could in theory publish an RSS feed with no order and no date which cause more problems.
We make the assumption that items will be in the correct order as that is what most implementations will do but as we can see here that isn't the case so we will need to make a change on how we handle this.
from n8n.
Moving to closed as this should now be resolved.
from n8n.
Related Issues (20)
- I discovered a bug with Node S3 where n8n interprets the bucket name as a subdomain and throws an execution error. (minio) HOT 4
- GMail Trigger : Fetching duplicate emails again HOT 6
- Problems with Telegram Trigger module HOT 2
- Google BigQuery Node Returns Integer Values as String Instead of Number HOT 2
- webhook pinned data is shown in already executed workflow HOT 4
- Wait node doesn't allow removing attribution for "form submission" HOT 2
- Jira node list custom fields not working HOT 1
- HTTP Request Tools: Subsequent AI calls with different parameters return identical responses HOT 1
- Redis Server HOT 6
- HubSpot Trigger API key should not be required HOT 3
- Webflow - Form Submissions HOT 2
- HTTP node Max Pages expression error HOT 1
- No paste option on context menu HOT 2
- Issue with autocomplete and external-secrets HOT 2
- Hive v3 - Execute responder always returns an error HOT 4
- OpenAI model node: 'json_schema' 'response_format.type' error HOT 1
- Google Service Account API - Crash during set up of HTTP request scopes HOT 1
- [Low Priority Bug/UI] HTML message status response not being rendered or parsed in the workflow. HOT 1
- GitLab trigger creates webhook on launch even when not needed HOT 1
- Email validation fails for example@localhost address HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from n8n.