Code Monkey home page Code Monkey logo

Comments (6)

N3evin avatar N3evin commented on August 23, 2024

Try to set to lowercase for pichu.

from amiiboapi.

DanTheMan827 avatar DanTheMan827 commented on August 23, 2024

Making the Pichu ID lowercase does in fact get rid of the errors for that, but the "No amiibo part of game series" are still present.

from amiiboapi.

N3evin avatar N3evin commented on August 23, 2024

Making the Pichu ID lowercase does in fact get rid of the errors for that, but the "No amiibo part of game series" are still present.

because no amiibo was with those ids are released so far. I will remove them for now.

Edit: Do try again, thanks for testing it out. I had removed those gameseries that does not exist. I guess I oversight it
Commit: 7f91e4d

from amiiboapi.

DanTheMan827 avatar DanTheMan827 commented on August 23, 2024

Why were they in the JSON then?

The tool validates the json by:

  • Ensuring all keys are lowercase and match the length requirements
  • Checks for missing images
  • Checks for missing game series
  • Checks for missing amiibo series
  • Checks to make sure at least one amiibo is part of a game series ID
  • Checks to make sure at least one amiibo is part of an amiibo series ID
  • Checks to make sure that at least one amiibo is part of a character ID

from amiiboapi.

DanTheMan827 avatar DanTheMan827 commented on August 23, 2024

You can find the source for the scanner here if you're interested, it's written in C# for .NET Core

https://github.com/DanTheMan827/AmiiboApiValidator

Maybe it'd be worthwhile to configure it as a GitHub Action for testing to catch any errors before they'd get merged?

from amiiboapi.

N3evin avatar N3evin commented on August 23, 2024

Why were they in the JSON then?

The tool validates the json by:

  • Ensuring all keys are lowercase and match the length requirements
  • Checks for missing images
  • Checks for missing game series
  • Checks for missing amiibo series
  • Checks to make sure at least one amiibo is part of a game series ID
  • Checks to make sure at least one amiibo is part of an amiibo series ID
  • Checks to make sure that at least one amiibo is part of a character ID

I guess a long time ago I did some wrong checking on an old script that I run to generate most of the stuff. The whole thing was set up when I was still studying, that's why on the site it's stated that it was for education purpose only.

You can find the source for the scanner here if you're interested, it's written in C# for .NET Core

https://github.com/DanTheMan827/AmiiboApiValidator

Maybe it'd be worthwhile to configure it as a GitHub Action for testing to catch any errors before they'd get merged?

Never heard of GitHub Action, this is totally new to me. Thank you, I would look at it when I had the time.

Edit: I will close the issue now.

from amiiboapi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.