TypeError in TSP notebook about alns HOT 4 CLOSED

I had a look at the recent changes to tsplib, @siljuovix. These turn out to have been substantial, and warrant changes on my end. I could reproduce the issue after upgrading my tsplib package to 0.7.0, and resolved the issues in #28.

Please have a look at the latest notebook, here!

from alns.

Hey @siljuovix, thanks for opening an issue! I can sadly not reproduce the problem locally.

From what I can tell from your tracebacks, in your notebook node is a list, rather than a tuple (lists cannot be hashed, tuples can). That's a bit weird, as they should be tuples when loaded from tsplib.

Can you check for me what data = tsplib95.load_problem('xqf131.tsp') returns? (this is called near the top of the notebook) In particular, what are the key-value types of data.node_coords?

from alns.

@N-Wouda Thank you for the fast reply!
data.node_coords is a dictionary like : 

{1: [0, 13], 2: [0, 26], 3: [0, 27], 4: [0, 39], ...}

Then after 

state = TspState(list(data.node_coords.items()), {})

node_coords passes as a list of tuples like: [(1,[0,13]), (2,[0,26]),...]

Also worth mentioning that I get a deprecation warning when using problem_load:

DeprecationWarning: Call to deprecated function (or staticmethod) load_problem. (Will be removed in newer versions. Use tsplib95.load instead.) -- Deprecated since version 7.0.0.

And this line:
optimal = data.trace_tours(solution)[0]

is also giving the following error:

TypeError Traceback (most recent call last)
in
----> 1 optimal = data.trace_tours(solution)[0]

~/.local/lib/python3.6/site-packages/tsplib95/models.py in trace_tours(self, tours)
425 """
426 solutions = []
--> 427 for tour in tours:
428 edges = utils.pairwise(tour)
429 weight = sum(self.get_weight(i, j) for i, j in edges)

TypeError: 'StandardProblem' object is not iterable

from alns.

from alns.