Code Monkey home page Code Monkey logo

Comments (7)

pm20390 avatar pm20390 commented on July 24, 2024

I've added this commit to my fork.

from angular-google-tag-manager.

lechatgraphique avatar lechatgraphique commented on July 24, 2024

Hi @pm20390,

Thanks for the fix on the import. The time that the modification is pushed, I made the modification on my side but it seems to have another error?

Error: export 'GoogleTagManagerConfiguration' (imported as 'GoogleTagManagerConfiguration') was not found in 'angular-google-tag-manager' (possibl e exports: GoogleTagManagerModule, GoogleTagManagerService)

public-api.ts
export * from './lib/angular-google-tag-manager.service'; export * from './lib/angular-google-tag-manager.module'; export * from './lib/google-tag-manager-config'; export * from './lib/angular-google-tag-manager-config.service';

Best regard

from angular-google-tag-manager.

pm20390 avatar pm20390 commented on July 24, 2024

Hi @lechatgraphique

I will double check later but that should be resolved by the last line in your public-api. I am using this currently without issue.

Are you sure you’ve imported GoogleTagManagerConfiguration correctly where you need to use it?

Best

from angular-google-tag-manager.

lechatgraphique avatar lechatgraphique commented on July 24, 2024

Thank you for your reply.
Logically it should work.
I show you

public-api.d.ts
image

app.module.ts
image
image
image

from angular-google-tag-manager.

pm20390 avatar pm20390 commented on July 24, 2024

If you need this change now, I would use my fork “ng-google-tag-manager” (available via npm) and then just switch back when it gets merged. Editing the .d.ts files for the built output won’t work.

from angular-google-tag-manager.

lechatgraphique avatar lechatgraphique commented on July 24, 2024

Ok thanks, I will do that :)

from angular-google-tag-manager.

lechatgraphique avatar lechatgraphique commented on July 24, 2024

Great thanks for the helping hand. It works damn ;)

from angular-google-tag-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.