Rename to zip215 vs ed25519? about fastcrypto HOT 5 CLOSED

@joyqvq let's check how zcash is handling this and definitely ensure we have clear comments in docs.

from fastcrypto.

I concern that when external users searches for Ed25519 in our codebase, it is hard to tell what zip215 is. IMO zip215 is the standard for verification, not for other representation of the eddsa key. Perhaps renaming the verify method to verify_with_zip215 is more appropriate?

from fastcrypto.

cc: @benr-ml who might have similar experience and ideas.

from fastcrypto.

I think that documenting this is enough - ZIP215 is just a set of additional verification criteria that all honestly generated signatures should satisfy.

from fastcrypto.

Great, makes sense: we should do exactly what zCash promotes in their zebra lib and docs and it seems they also refer it as ed25519 with zip215 validation https://github.com/ZcashFoundation/ed25519-zebra

from fastcrypto.