Fixing V_FLOW data type measurement unit about mysensors HOT 11 CLOSED

As far as Home Assistant and its MySensors integration is concerned, there's no need for a new release of MySensors. If the documentation and example for this message type is updated that's enough for Home Assistant to rely on that when setting default unit of measurement for this sensor type.

from mysensors.

m3/h sounds good to me.

from mysensors.

m3/h sounds good to me.

ok good, so if no other will make any exception to this in the next days, i'll add a pull request for changing this, and once i'll have access to CMS will change this in the page accordingly. I'll move on the same way on the home assistant pull request that i've done.

from mysensors.

I think you meant to tag Mikael.

from mysensors.

I've just made the pull request. I'll need to change the CMS page for this.

The pages that i need to change is https://www.mysensors.org/download/serial_api_20 (which reports wrong V_FLOW measurement unit (meter...) and this should be switched to m3/h

from mysensors.

@mfalkvidd for this kind of change that will imply some changes in the home assistant release, I guess we'll need a new release of mysensors here, right?

from mysensors.

Sorry, I don't know. I am not aware of how the Home Assistant release process works, nor how it could affect MySensors. I have trouble seeing how changing a code comment would trigger a new release; it's not like we're making breaking changes to an API.

from mysensors.

Sorry, I don't know. I am not aware of how the Home Assistant release process works, nor how it could affect MySensors. I have trouble seeing how changing a code comment would trigger a new release; it's not like we're making breaking changes to an API.

Ok,
there is anyway some bidirectional relationship between Home Assistant integration and MySensors. I understand here we have only a change in the example and in the documentation, so It could be ok to not make a new release. I'm not aware of the in place practices between MySensors and HAss, but if changing MySensors doc and simply link the development branch for the new example, this is fine also for me. Let's finalize this way (as soon as jenkins is ok with build)

from mysensors.

@mfalkvidd this is completed, can you merge this? So that i'll move on things on HA as well and ask merge also the PR on their side.

thanks
Paolo

from mysensors.

#1541 merged

from mysensors.

I've just made the pull request. I'll need to change the CMS page for this.

The pages that i need to change is https://www.mysensors.org/download/serial_api_20 (which reports wrong V_FLOW measurement unit (meter...) and this should be switched to m3/h

@mfalkvidd who can fix and publish the cms page? I think that also for the example in the Water sensor, as discussed before, this should be switched to the dev branch so to show the right example without need for a release

from mysensors.