Comments (2)
gorner
commented on July 17, 2024
1
For now, for the app I'm working on, I've realized it'll probably be sufficient to just specify ember-basic-dropdown v6 in npm overrides (or equivalently yarn resolutions).
Just a heads-up for anyone else using this workaround, it also worked with EBD v7 but does not work with EBD v8+ due to its conversion to the v2 addon format:
Error: ember-date-components needs to depend on ember-auto-import in order to use ember-basic-dropdown
at Class.registerV2Addon (<app_path>/node_modules/@embroider/addon-shim/src/index.js:122:27)
at Class.included (<app_path>/node_modules/@embroider/addon-shim/src/index.js:42:18)
at Class.superWrapper [as included] (<app_path>/node_modules/core-object/lib/assign-properties.js:34:20)
at <app_path>/node_modules/ember-cli/lib/models/addon.js:497:26
at Array.reduce (<anonymous>)
at Class.eachAddonInvoke (<app_path>/node_modules/ember-cli/lib/models/addon.js:494:24)
at Class.included (<app_path>/node_modules/ember-cli/lib/models/addon.js:769:10)
at Class.superWrapper [as included] (<app_path>/node_modules/core-object/lib/assign-properties.js:34:20)
at Class.included (<app_path>/node_modules/ember-date-components/index.js:9:26)
at Class.superWrapper [as included] (<app_path>/node_modules/core-object/lib/assign-properties.js:34:20)
at <app_path>/node_modules/ember-cli/lib/broccoli/ember-app.js:653:15
at Array.forEach (<anonymous>)
at EmberApp._notifyAddonIncluded (<app_path>/node_modules/ember-cli/lib/broccoli/ember-app.js:651:25)
at new EmberApp (<app_path>/node_modules/ember-cli/lib/broccoli/ember-app.js:137:10)
at module.exports (<app_path>/ember-cli-build.js:60:13)
at Builder.readBuildFile (<app_path>/node_modules/ember-cli/lib/models/builder.js:49:14)
at Builder.setupBroccoliBuilder (<app_path>/node_modules/ember-cli/lib/models/builder.js:63:22)
at new Builder (<app_path>/node_modules/ember-cli/lib/models/builder.js:29:10)
at ServeTask.run (<app_path>/node_modules/ember-cli/lib/tasks/serve.js:49:7)
at <app_path>/node_modules/ember-cli/lib/models/command.js:238:24
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Class.run (<app_path>/node_modules/ember-cli/lib/commands/serve.js:106:5)
from ember-date-components.
gorner
commented on July 17, 2024
I looked into this update this weekend and discovered a bunch of other updates that seemed to be required to ensure compatibility with newer versions of Ember. With that caveat, I got most things working, except for the Embroider runs of ember-try, which gave me a lot of errors along the lines of TypeError: _externals_moment__WEBPACK_IMPORTED_MODULE_1__.isMoment is not a function which didn't work even if I tried things like import { isMoment } from 'moment'. Apart from that attempt, however, I didn't need to touch any of the add-on code itself.
If anyone's curious, this is my working branch: https://github.com/gorner/ember-date-components/tree/update-ember-basic-dropdown-v6
For now, for the app I'm working on, I've realized it'll probably be sufficient to just specify ember-basic-dropdown v6 in npm overrides (or equivalently yarn resolutions).
Edit: I've tried a couple of other things since then (including moving Moment to dependencies) to no avail. But on review, it looks like the current release may not work with Embroider either? Perhaps I will just go ahead and create the PR.
from ember-date-components.
Related Issues (20)
- Missing Date Time Picker Placeholders HOT 3
- importCSS: false doesn't seem to work HOT 2
- getDatePicker test helper doesn't take year into consideration
- selectDate test helper HOT 1
- More options when range=true HOT 1
- .date-picker__button--focus class not being applied correctly HOT 1
- Datepicker popup misaligned when button is floated HOT 1
- Picking a date triggers a form action
- .git folder available on npm HOT 5
- Update docs to indicate value=[prop] is required HOT 1
- Suggestion: add "ember install ember-moment" to docs. HOT 4
- Dates are shown in the wrong weekday. HOT 3
- Error in 2.1.0 with min & max value HOT 1
- Ember power select breaks this addon HOT 5
- Prettier run messed up Ember.get calls HOT 2
- Is this project active? HOT 2
- time-picker button not updating after select HOT 2
- DatePicker Issue - Unable to select the dates for the second time HOT 3
- Adding other package support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-date-components.