org.mybatis.spring.transaction.SpringManagedTransaction.logger should be static about spring HOT 4 CLOSED

The current logger is a class instance:
private final Log logger = LogFactory.getLog(getClass());

This was probably copy pasta from elsewhere that actually needed to use getClass(). I don't see any reason why the Log can't be static with SpringManagedTransaction.class passed to getLog() .

from spring.

Some time ago (in the times of RCs) Simo advised us to change that due to this:
http://wiki.apache.org/commons/Logging/StaticLog

Not sure if using statics is a real problem given that this is how the whole spring framework is coded...

from spring.

If this is a deliberate use of the transient logger pattern, then it needs to be applied across the board to do much good. At present, only SpringManagedTransaction and SqlSessionFactoryBean have non-static loggers (and it's inconceivable to me that only mybatis-spring and not mybatis core would be deployed in a shared directory). Also, the implementation of LogFactory in mybatis-3.2.2 is incompatible with repeated calls to getLog(): it's simply too slow to be used this way.

Hunter's point about the misuse of getClass() is also well taken. There may be times when this is an appropriate thing to do, but they are rare, and this is not one of them.

from spring.

Yep, that code does not make sense I will change it to the classic method.

from spring.