Add support for HikariCP (as suggested replacement for bonecp) about guice HOT 14 CLOSED

:) Feel free to fork early if you think you'll be delayed in the PR. And thanks for your efforts.

from guice.

@robotdan Thanks! I am quite busy and it is faster to review a PR than to program this myself. So it would be very appreciated. :)

from guice.

I am using HikariCP w/ Mybatis, no issues that I know.

• mybatis 3.4.6
• mybatis-guice 3.10
• Hikari 2.6.1

from guice.

Hi, @robotdan, Thanks for confirming it does work. What is missing is direct integration though as found in this package. If possible maybe you could build and submit a pull request that would provide native support as with other datasources? I'm not super familar in this are of code and only noted this needed done after reviewing current support and libaries that are no longer supported.

from guice.

@hazendaz Sure, I'll see if I can boil something down and put together a PR.

from guice.

FYI, I haven't forgotten about this. I have it mostly coded, just finishing the tests. If anyone is in a hurry for it I can push my fork before I submit a PR.

from guice.

Thanks @robotdan !

I will not have time to review your changes before next week, so no hurry.

from guice.

Did a version of HikariCP datasource provider get pushed anywhere we can grab it from?

from guice.

Not yet. I was waiting for @robotdan in case he had a PR ready.

from guice.

Sorry for the delay, you know how it goes. 😁 I do have a PR mostly ready. I'll get it submitted shortly.

from guice.

Submitted PR #168 - may still need some work. I'm happy to continue to contribute to it if you need anything. We have been using MyBatis + HikariCP for ~ 5 years.

from guice.

Thank you @robotdan . Pretty much what I was expecting. I'll take it for a spin locally whilst waiting for the PR to propagate through to release.

from guice.

@gibsonm You're welcome, let me know if I can help with anything else.

from guice.

Fixed with PR #168

from guice.