parse: does not understand case fallthrough tokens about sh HOT 9 CLOSED

PR created: NixOS/nixpkgs#21695
edit: merged.

from sh.

Ah, this is simply a bash token (not POSIX) that I hadn't added yet. Thanks for spotting!

from sh.

No problem. Thanks for sharing this code. Aside from that one token it was perfectly happy to apply a consistent style to a bunch of organically grown scripts that each contained multiple different styles.

If I were a stronger Go programmer and had more time I'd have tried to fix it myself and open a PR, but I figured a good bug report would still be appreciated.

Again, thanks for sharing your code!

from sh.

No problem. Thanks for sharing this code. Aside from that one token it was perfectly happy to apply a consistent style to a bunch of organically grown scripts that each contained multiple different styles.

Cool :)

If I were a stronger Go programmer and had more time I'd have tried to fix it myself and open a PR, but I figured a good bug report would still be appreciated.

Parsers become stupidly complex very easily, especially one that parses Shell. So no worries on that front - it's much easier for me to fix things like these as I'm already familiar with the codebase.

from sh.

Thanks for the quick fix! The new version no longer throws the error for me.
I packaged this tool for NixOS yesterday (NixOS/nixpkgs#16247) and will be updating the package to point to this code.

from sh.

@nshalman could you please update it to 0.2.0 there? Thanks!

from sh.

As shown above, I've created NixOS/nixpkgs#19524
Thanks for the reminder!
edit: It's been merged.

from sh.

@nshalman thanks!

from sh.

@nshalman please update to 1.1.0 :)

from sh.