Comments (9)
PR created: NixOS/nixpkgs#21695
edit: merged.
from sh.
Ah, this is simply a bash token (not POSIX) that I hadn't added yet. Thanks for spotting!
from sh.
No problem. Thanks for sharing this code. Aside from that one token it was perfectly happy to apply a consistent style to a bunch of organically grown scripts that each contained multiple different styles.
If I were a stronger Go programmer and had more time I'd have tried to fix it myself and open a PR, but I figured a good bug report would still be appreciated.
Again, thanks for sharing your code!
from sh.
No problem. Thanks for sharing this code. Aside from that one token it was perfectly happy to apply a consistent style to a bunch of organically grown scripts that each contained multiple different styles.
Cool :)
If I were a stronger Go programmer and had more time I'd have tried to fix it myself and open a PR, but I figured a good bug report would still be appreciated.
Parsers become stupidly complex very easily, especially one that parses Shell. So no worries on that front - it's much easier for me to fix things like these as I'm already familiar with the codebase.
from sh.
Thanks for the quick fix! The new version no longer throws the error for me.
I packaged this tool for NixOS yesterday (NixOS/nixpkgs#16247) and will be updating the package to point to this code.
from sh.
@nshalman could you please update it to 0.2.0 there? Thanks!
from sh.
As shown above, I've created NixOS/nixpkgs#19524
Thanks for the reminder!
edit: It's been merged.
from sh.
@nshalman thanks!
from sh.
@nshalman please update to 1.1.0 :)
from sh.
Related Issues (20)
- Brace expansion: zero-padding and capital letters not working HOT 2
- expand: FuncEnviron provided environment variables will not copy cross pipe HOT 2
- Unexpected reformatting of multi-line commands HOT 1
- Wrong parsing of for loop HOT 2
- shfmt: places ";then" on wrong line when using heredoc as stdin for a command
- Request: Support for new POSIX 2022 sh features HOT 1
- shfmt breaks hashes for associative arrays that contain dashes HOT 2
- Inline formatting single file: Breaks symlink and creates a regular file instead of retaining symlink HOT 1
- cmd/shfmt: document how --filename relates to EditorConfig support HOT 6
- When processing a bash script, `shfmt` defaults to using `POSIX` syntax rules instead of bash-specific syntax HOT 1
- editorconfig - accept simplify and minify flags? HOT 1
- Multiple commands in one line HOT 2
- emulate beautysh `--force-function-style` HOT 1
- interp: bash runs scripts if kernel returns ENOEXEC HOT 1
- Formatting suggestion: if-blocks with multiple conditions
- Space redirects `-sr` also seem to convert space indents to tabs HOT 2
- interp: here-doc backslash is not preserved HOT 1
- syntax: Parser does not handle unescaped slash as original value in replacement parameter expansion HOT 3
- request: Include Windows ARM64 precompiled binary
- man page: incorrect statement regarding use of `-` (read from stdin) and `--filename` flag
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sh.