Code Monkey home page Code Monkey logo

Comments (12)

loganmc10 avatar loganmc10 commented on May 28, 2024 1

I believe you need to set PIE=1, not PIC=1

from mupen64plus-ui-console.

Enverex avatar Enverex commented on May 28, 2024

Is it worth adding the PIE=1 bit to the main documentation? It doesn't build on Arch Linux without adding this which confused me for a good few hours (considering that it complains about PIC and not PIE).

from mupen64plus-ui-console.

loganmc10 avatar loganmc10 commented on May 28, 2024

Yeah I noticed it's required in the latest Ubuntu as well, it might be worth it to make it the default

from mupen64plus-ui-console.

richard42 avatar richard42 commented on May 28, 2024

Are people seeing the build errors with x86/amd64 machines as well, or is this only on ARM cpus?

from mupen64plus-ui-console.

loganmc10 avatar loganmc10 commented on May 28, 2024

I had this on Ubuntu x64

from mupen64plus-ui-console.

richard42 avatar richard42 commented on May 28, 2024

This kind of sucks. The PIE option is used for hardening executables against certain types of vulnerabilities. I don't think it's really necessary for mupen64plus. I don't know why the distro or compiler would change default options to make this required for all executables; it seems like this would cause a lot of grief. It would be a good idea to add something to the README file or other documentation to warn people about this, but I would not want to make the PIE=1 option the default yet.

from mupen64plus-ui-console.

loganmc10 avatar loganmc10 commented on May 28, 2024

Yeah it seems like Ubuntu did it starting in 16.10:

https://lists.ubuntu.com/archives/snapcraft/2017-February/003339.html

I'm not sure why it seems to be forced, but I definitely ran into this issue in x64 Ubuntu

from mupen64plus-ui-console.

loganmc10 avatar loganmc10 commented on May 28, 2024

Also:

https://wiki.ubuntu.com/SecurityTeam/PIE

from mupen64plus-ui-console.

loganmc10 avatar loganmc10 commented on May 28, 2024

Sorry for the triple post maybe https://github.com/mupen64plus/mupen64plus-ui-console/blob/master/projects/unix/Makefile#L87 just needs to be changed to no-pie is it case sensitive?

from mupen64plus-ui-console.

richard42 avatar richard42 commented on May 28, 2024

it looks to me like GCC is supposed to support both -no-pie and -no-PIE. Can somebody with ubuntu 16.10 test, to see if changing the case resolves this?

from mupen64plus-ui-console.

loganmc10 avatar loganmc10 commented on May 28, 2024

I tried on Ubuntu 17.04, I had to add -no-pie to the linker flags. It worked and I submitted a PR: #36

But then Travis failed. I guess -no-pie is only available on later GCC versions?

from mupen64plus-ui-console.

richard42 avatar richard42 commented on May 28, 2024

I have GCC 5.4.0, and it does accept the "--no-pie" option, but not "-no-pie"

from mupen64plus-ui-console.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.