Ghidra produses strange code when meets with inderect addressing. Fo

<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github

Base + offset addressing mode about ghidra HOT 3 OPEN

mumbel commented on August 29, 2024

Base + offset addressing mode

from ghidra.

Comments (3)

mumbel commented on August 29, 2024

I've been finding bugs and just generic issues in the SLEIGH (also adjusting SLEIGH for improved pcode) with help from a ghidra dev. The sha, extr, and few others (plus their variants) have been problematic translating into SLEIGH with my initial attempts. My current local changes have this as the output:

void FUN_8006f8f4(void)
{
  uint uVar1;
  uint uVar2;
  
  uVar2 = 0;
  do {
    if (true) {
      uVar1 = uVar2 << 2;
    }
    else {
      uVar1 = uVar2;
      if (true) {
        uVar1 = 0;
      }
    }
    uVar2 = uVar2 + 1 & 0xff;
    *(undefined4 *)(&UNK_d00052e0 + uVar1) = 0;
    *(undefined4 *)(&UNK_d0005320 + uVar1) = 0;
  } while (uVar2 < 0x10);
  a0 = &DAT_d000bc00;
  return;
}

void FUN_8006f9be(void)
{
  int iVar1;
  
  a0 = &DAT_d000bc00;
  iVar1 = FUN_800e3c2c();
  if (iVar1 != 1) {
    *(char *)(a0 + -0x1e5b) = *(char *)(a0 + -0x1e5b) + '\x01';
  }
  return;
}

from ghidra.

mumbel commented on August 29, 2024

29f267b seems like a noticeable improvement.

{
  int iVar1;
  uint uVar2;
  
  uVar2 = 0;
  do {
    iVar1 = uVar2 * 4;
    uVar2 = uVar2 + 1 & 0xff;
    *(undefined4 *)(&UNK_d00052e0 + iVar1) = 0;
    *(undefined4 *)(&UNK_d0005320 + iVar1) = 0;
  } while (uVar2 < 0x10);
  a0 = &DAT_d000bc00;
  return;
}

from ghidra.