Code Monkey home page Code Monkey logo

Comments (6)

cherniavskii avatar cherniavskii commented on July 22, 2024 2

@michelengelen

The flip was disabled in #837 (comment). I believe the goal was to avoid this effect:

Screen.Recording.2024-06-14.at.17.24.29.mov

How about doing this instead?

{
  name: 'flip',
  enabled: true,
  options: {
    rootBoundary: 'document'
  }
},

from mui-x.

michelengelen avatar michelengelen commented on July 22, 2024

Hey @simbahandiane the sandbox you shared is not public.
Could you change that so we can have a look?
Thanks! 🙇🏼

from mui-x.

simbahandiane avatar simbahandiane commented on July 22, 2024

@michelengelen Can you try this link and let me know if you can access it now?

from mui-x.

michelengelen avatar michelengelen commented on July 22, 2024

Yes, it works.
I did check the underlying code for the panel and I think we could just change the default behavior.

diff --git a/packages/x-data-grid/src/components/panel/GridPanel.tsx b/packages/x-data-grid/src/components/panel/GridPanel.tsx
index a82b53b37..6109783f4 100644
--- a/packages/x-data-grid/src/components/panel/GridPanel.tsx
+++ b/packages/x-data-grid/src/components/panel/GridPanel.tsx
@@ -79,7 +79,10 @@ const GridPanel = React.forwardRef<HTMLDivElement, GridPanelProps>((props, ref)
     () => [
       {
         name: 'flip',
-        enabled: false,
+        enabled: true,
+        options: {
+          rootBoundary: 'document'
+        },
       },
       {
         name: 'isPlaced',

Should we just make this change @cherniavskii ?

from mui-x.

michelengelen avatar michelengelen commented on July 22, 2024

@michelengelen

The flip was disabled in #837 (comment). I believe the goal was to avoid this effect:

Screen.Recording.2024-06-14.at.17.24.29.mov
How about doing this instead?

{
  name: 'flip',
  enabled: true,
  options: {
    rootBoundary: 'document'
  }
},

Yes, sounds good.
I have updated my diff.
Lets label this a good first issue

from mui-x.

simbahandiane avatar simbahandiane commented on July 22, 2024

@michelengelen @cherniavskii We are currently in version 6. Is there any way that this fix can also be published on version 6? If it can't be, is there a work around that we can do for now?

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.