[data grid] Format row count numbers in pagination about mui-x HOT 13 OPEN

@michelengelen do you think it would justify a doc example?

Probably ... its not easy to find that feature otherwise

I'll reopen and add it to the recipe umbrella!

from mui-x.

This looks like a sub-issue of the parent one: mui/material-ui#24495. I proposed a possible solution a while back: mui/material-ui#24495 (comment).

Side observations:

1. all our locales number formatting feels straight wrong:

I would expect:

 `${visibleCount.toLocaleString('fr-FR')} sur ${totalCount.toLocaleString('fr-FR')}`, 

e.g. if Pennylane adopts our data grid, it will be wrong. My default OS language is English (so what toLocaleString will output), but I might set the language picker in their UI to French so I can take screenshots for the accountant. The data grid would show the number assuming the English locale, not the French one ❌.

from mui-x.

Looking at the code, it seems that you have a labelDisplayedRows locale key on the MuiTablePagination locale entry of the grid (those nested locale entry are super hard to understand IMHO).

This would be nice to have an example if it does work
And if it doesn't and you do need to create a custom pagination component, then I fully agree that we could improve the DX 👍

from mui-x.

Yeah, I forget that one every time 😆
The Base UI team is experiencing similar issues with the NumberInput, maybe we will be able to use the same approach in the end.

from mui-x.

Probably already possible with a custom pagination and the TablePagination component ... the prop labelDisplayedRows looks like it would do the trick here

But this seems like a very heavy customization for such a little thing!

@mui/xgrid WDYT?

from mui-x.

Oh yes, that actually works!

FYI: numbers were artificially created to test this ((10000).toLocaleString('en'))

Thanks @flaviendelangle for this tip! 👍🏼

slotProps={{
  pagination: { labelDisplayedRows: ({ from, to, count }) => `${from.toLocaleString('en')}-${to.toLocaleString('en')}`},
}}

from mui-x.

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@Janpot: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

from mui-x.

@michelengelen do you think it would justify a doc example?

from mui-x.

its not easy to find that feature otherwise

It would be nice to have some kind of API pages for the slots, but that's a big initiative and not specific to this prop in particular.

from mui-x.

Respecting the decision ofcourse but gonna play a bit advocate of the devil here. To me it seems strange that the localeText is not formatting the numbers it interpollates by default. Imagining there was a text with a date, we wouldn't just stringify that date neither, we'd format it to the user locale. It feels a bit like this API is only doing half its job this way. I find it hard to imagine that not formatting the numbers would be part of more than 5% of use-cases out there.

from mui-x.

Related issues #7457

from mui-x.

Right, SSR, good concern 👍

from mui-x.

🤔 Actually, if the texts are already localized, why can't the localization of the numbers follow the text? If there is an actual SSR problem, shouldn't it then be already present in the current localization of the texts?

from mui-x.