Code Monkey home page Code Monkey logo

Comments (3)

michelengelen avatar michelengelen commented on July 18, 2024

thanks @EmilianoLam ... I can confirm this bug.

Steps to reproduce:

  1. enter edit mode on rating cell
  2. change rating with arrows
  3. exits edit mode after first arrow key (<- first bug)

Second bug:

  1. enter edit mode on a value 5 or value 1 rating
  2. go one up or down to reach value 0 (separate bug from **Rating** component here)
  3. demo crashes with following error message (from local dev instance):
react-dom.development.js:22834 Uncaught TypeError: Cannot read properties of null (reading 'focus')
    at handleRef (renderEditRating.tsx:18:68)
    at setRef (setRef.js:20:5)
    at eval (useForkRef.js:24:60)

It seems that there are several problems here:

  1. The edit mode stops whenever there is a change
  2. the element with value 0 cannot be found
  3. unrelated: the Rating component has a bug where pressing arrow down increses the value

Related issue for the Rating component here

from mui-x.

cherniavskii avatar cherniavskii commented on July 18, 2024

Fixed by #12335 and #12315

from mui-x.

github-actions avatar github-actions commented on July 18, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@EmilianoLam: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.